Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: CharacterButtonのメニューが常に下方向に展開されるようにする #1291

Merged
merged 4 commits into from
Apr 27, 2023
Merged

ENH: CharacterButtonのメニューが常に下方向に展開されるようにする #1291

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
038ec58
ENH: CharacterButtonのメニューが常に下方向に展開されるようにする
sabonerune Mar 31, 2023
cf01c89
FIX: コメント追加
sabonerune Apr 19, 2023
1e1cecf
FIX: コメント追記
sabonerune Apr 24, 2023
9a25d08
コメント追記
sabonerune Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/components/CharacterButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<q-btn
flat
class="q-pa-none character-button"
ref="buttonRef"
:disable="uiLocked"
:class="{ opaque: loading }"
>
Expand All @@ -23,6 +24,8 @@
class="character-menu"
transition-show="none"
transition-hide="none"
:max-height="maxMenuHeight"
@before-show="updateMenuHeight"
>
<q-list style="min-width: max-content" class="character-item-container">
<q-item
Expand Down Expand Up @@ -179,8 +182,8 @@
</template>

<script setup lang="ts">
import { debounce } from "quasar";
import { computed, ref } from "vue";
import { debounce, QBtn } from "quasar";
import { computed, Ref, ref } from "vue";
import { base64ImageToUri } from "@/helpers/imageHelper";
import { useStore } from "@/store";
import { CharacterInfo, SpeakerId, Voice } from "@/type/preload";
Expand Down Expand Up @@ -291,6 +294,22 @@ const reassignSubMenuOpen = debounce((idx: number) => {
arr[idx] = true;
subMenuOpenFlags.value = arr;
}, 100);

// 高さを制限してメニューが下方向に展開されるようにする
const buttonRef: Ref<InstanceType<typeof QBtn> | undefined> = ref();
Hiroshiba marked this conversation as resolved.
Show resolved Hide resolved
const heightLimit = "65vh"; // QMenuのデフォルト値
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえず元々の動作は変えないようにしました。
参照する方法がなさそうなのでハードコートしました。

const maxMenuHeight = ref(heightLimit);
const updateMenuHeight = () => {
if (buttonRef.value == undefined)
throw new Error("buttonRef.value == undefined");
const el = buttonRef.value.$el;
if (!(el instanceof Element)) throw new Error("!(el instanceof Element)");
const buttonRect = el.getBoundingClientRect();
// QMenuは展開する方向のスペースが不足している場合、自動的に展開方向を変更してしまうためmax-heightで制限する。
// AudioDetailよりボタンが下に来ることはないのでその最低高185pxに余裕を持たせた170pxを最小の高さにする。
// pxで指定するとウインドウサイズ変更に追従できないので ウインドウの高さの96% - ボタンの下端の座標 でメニューの高さを決定する。
maxMenuHeight.value = `max(170px, min(${heightLimit}, calc(96vh - ${buttonRect.bottom}px)))`;
Hiroshiba marked this conversation as resolved.
Show resolved Hide resolved
};
</script>

<style scoped lang="scss">
Expand Down