Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust]CI上でのlintエラーを修正した #133

Merged
merged 1 commit into from
May 15, 2022
Merged

[Rust]CI上でのlintエラーを修正した #133

merged 1 commit into from
May 15, 2022

Conversation

qwerty2501
Copy link
Contributor

内容

CI上でlintが走るように設定してあるのですが、それが仮実装のコードでエラー出るようになってしまっているのでその修正です

関連 Issue

refs #128

@qwerty2501 qwerty2501 mentioned this pull request May 15, 2022
Merged
Hiroshiba
Hiroshiba approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！
ついでにformatterも導入しちゃいたいところですね

@Hiroshiba Hiroshiba merged commit ffd69d3 into VOICEVOX:rust May 15, 2022
@qwerty2501
Copy link
Contributor Author

@Hiroshiba formatチェックならすでに入ってますhttps://github.com/VOICEVOX/voicevox_core/blob/rust/.github/workflows/test.yml#L12

@Hiroshiba
Copy link
Member

あ、本当ですね！！　ありがとうございます！！

qwerty2501 added a commit to qwerty2501/voicevox_core that referenced this pull request Jul 23, 2022
@qwerty2501
CI上でのlintエラーを修正した (VOICEVOX#133)
9ca1689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwerty2501 @Hiroshiba