[Rust]簡単なテストコードとtestingライブラリの導入 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pull requestのときに毎回テストを走らせるには、 voicevox_core/.github/workflows/build.yml Lines 4 to 7 in 4592b93 |
qwerty2501
commented
May 15, 2022
| @@ -13,5 +13,9 @@ derive-new = "0.5.9" | |||
| once_cell = "1.10.0" | |||
| thiserror = "1.0.31" | |||
|
|
|||
| [dev-dependencies] | |||
| rstest = "0.12.0" | |||
| pretty_assertions = "1.2.1" | |||
There was a problem hiding this comment.
rstest は parameterized testや fixtureを提供できるらしいtesting libraryで今回は parameterized testを行うために導入
pretty_assertions は標準ライブラリにある assert_eq!, assert_ne! をリッチにしたもので、差分の表示が色付きでわかりやすく表示される rustのバージョンがあたらしくなってからは各test moduleごとにuse する必要が出たが、他に有力そうなものがなさそうだったので採用
手探りなのでこっちのがいいよ！ってあったら教えてください
qwerty2501
changed the title
参考になりそうな簡単なテストコードと独断ですがtestingライブラリを導入しました
qwerty2501
force-pushed
the
feature/added_unit_test_and_testing_libs
branch
from
538fa2f to
427d340
Compare
qwerty2501
commented
May 15, 2022
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use pretty_assertions::assert_eq; |
There was a problem hiding this comment.
pretty_assertionsを使う場合はこんな感じで各test module内で useする必要があるらしい
|
@Hiroshiba 提示された書き方だとなんかエディタ上でエラーが出るので若干違いますが pull_requestも含めるようにしました |
qwerty2501
added a commit
to qwerty2501/voicevox_core
that referenced
this pull request
Jul 23, 2022
* 簡単なテストコードとtestingライブラリの導入 参考になりそうな簡単なテストコードと独断ですがtestingライブラリを導入しました * pull_request時にtestが実行されるようにした
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
参考になりそうな簡単なテストコードと独断ですがtestingライブラリを導入しました
関連 Issue
refs #128, #133
その他
#133 がmergeされないとレビューできないので #133 からレビューする必要がある