-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust]簡単なテストコードとtestingライブラリの導入 #134
Merged
Hiroshiba
merged 2 commits into
VOICEVOX:rust
from
qwerty2501:feature/added_unit_test_and_testing_libs
May 15, 2022
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
name: test workflow | ||
on: [push] | ||
on: [push, pull_request] | ||
jobs: | ||
rust-lint: | ||
runs-on: ubuntu-latest | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ use std::sync::Mutex; | |
*/ | ||
|
||
#[repr(C)] | ||
#[derive(Debug, PartialEq)] | ||
#[allow(non_camel_case_types)] | ||
pub enum VoicevoxResultCode { | ||
// C でのenum定義に合わせて大文字で定義している | ||
|
@@ -214,3 +215,20 @@ pub extern "C" fn voicevox_error_result_to_message( | |
) -> *const c_char { | ||
internal::voicevox_error_result_to_message(result_code).as_ptr() as *const c_char | ||
} | ||
|
||
#[cfg(test)] | ||
mod tests { | ||
use super::*; | ||
use pretty_assertions::assert_eq; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pretty_assertionsを使う場合はこんな感じで各test module内で useする必要があるらしい |
||
|
||
#[rstest] | ||
#[case(Ok(()), VoicevoxResultCode::VOICEVOX_RESULT_SUCCEED)] | ||
#[case( | ||
Err(Error::NotLoadedOpenjtalkDict), | ||
VoicevoxResultCode::VOICEVOX_RESULT_NOT_LOADED_OPENJTALK_DICT | ||
)] | ||
fn convert_result_works(#[case] result: Result<()>, #[case] expected: VoicevoxResultCode) { | ||
let (_, actual) = convert_result(result); | ||
assert_eq!(expected, actual); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,6 @@ mod result; | |
|
||
use error::*; | ||
use result::*; | ||
|
||
#[cfg(test)] | ||
use rstest::*; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rstest は parameterized testや fixtureを提供できるらしいtesting libraryで今回は parameterized testを行うために導入
pretty_assertions は標準ライブラリにある assert_eq!, assert_ne! をリッチにしたもので、差分の表示が色付きでわかりやすく表示される rustのバージョンがあたらしくなってからは各test moduleごとにuse する必要が出たが、他に有力そうなものがなさそうだったので採用
手探りなのでこっちのがいいよ!ってあったら教えてください