Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust]C++ unix向けのexampleを修正する #197
[Rust]C++ unix向けのexampleを修正する #197
Changes from 7 commits
8b43c0a
9967997
b78538d
3f0f0d0
7af02c1
dfdf9a9
04f45ff
2fd4103
5e623bb
4f57588
f20b272
6610aa9
a7b924f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onnxruntimeの配置はcmakeで行うようにしてあるので削除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このexampleはビルド済みcoreをダウンロードして使う想定(coreのビルド環境がなくても良い想定)でした。
なのでこのダウンロード工程と、あとcmakeの変更がいりそうです。
(気づくのが遅れてしまって申し訳ないです。。)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すっかり失念していました……。確かに元々は C/C++ の開発環境さえあれば試せる感じに作っていました。onnxruntime の自動配置は便利だと思いつつ見ていましたが、ビルド済みcore や onnxruntime をユーザーが取ってくるようにする方が良いかもですね(親切に設計するとしても、プロジェクトのルートにある configure.py を再整備して使ってもらうようにする方が良いかもしれません)。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ダウンロードする必要がある旨記載しました
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configure.pyの再整備は賛成です!rust化完了後にissue作りたいですね