Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a tieoff method for module instances with unconnected inputs #811
base: master
Are you sure you want to change the base?
Adds a tieoff method for module instances with unconnected inputs #811
Changes from 1 commit
f5d8264
c288051
143a4fa
c6ae430
75b073e
2483b43
59cabc1
f319fde
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an important condition to document the behaviour of.
The name of this boolean is
useVccInverter
but then when it gets passed toconnectToStaticNet()
it becomes itsconnectToVcc
argument which does not seem to reconcile, because it doesn't look like this latter method does any inversion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified the code to clarify and harmonize the usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
connectToVCC
is true, this would also make the port logically connected to VCC (whereas if you're relying on the inverter, shouldn't it be GND?)EDIT: Perhaps not relevant if we stop inverting.