ci: use GitHub CLI to download M+ libmicroros #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of dsaltares/fetch-gh-release-asset. Works just as well and also supports downloading assets from draft releases (which we'll need later).
|
Unfortunately the (misconfigured) (note: that build failed, but not because of the changes in this PR, just the known issues with the |
GH CLI requires a token to download releases when used in GHA, so acquire one and pass it to GH CLI.
That way we don't have to start looking for it after the download is complete, but can just assume it has a certain name.
gavanderhoorn
force-pushed
the
ci_switch_to_gh_cli
branch
from
19b8bf8 to
0e20389
Compare
ted-miller
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title.
This switches to the GH CLI for interaction with releases of
micro_ros_motoplusfrom the currently useddsaltares/fetch-gh-release-asset.This works just as well and also supports downloading assets from draft releases (which we'll need later).