Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to dotnet SDK 8.0.303 #58

Merged
merged 17 commits into from
Jul 19, 2024
Merged

Upgrade to dotnet SDK 8.0.303 #58

merged 17 commits into from
Jul 19, 2024

Conversation

m-ringler
Copy link
Contributor

@m-ringler m-ringler commented Jul 18, 2024

Description

  • Upgrade czishrink to dotnet SDK 8.0.303
  • Disable megalinter for C# source files (the tools aren't working properly, and their rules partially conflict with StyleCop.Analyzers)
  • Fix various megalinter warnings and errors (in particular YAML schema validation with V8R)
  • Add a configuration file for YAML schema validation in vscode (necessary because V8R produces unhelpful error messages like './.mega-linter.yml# must NOT have additional properties' that don't really tell you what's wrong)

With this PR all github actions should be up and running again.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I updated the version of czicompress
  • New and existing unit tests pass locally with my changes.

@m-ringler m-ringler added cla Contributor License Agreement sent to Admin CI/CD czishrink The issue or PR affects czishrink .NET Pull requests that update .net code labels Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.87%. Comparing base (7e918e0) to head (7f5cf5b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   77.87%   77.87%           
=======================================
  Files          59       59           
  Lines        1921     1921           
  Branches      122      122           
=======================================
  Hits         1496     1496           
  Misses        401      401           
  Partials       24       24           
Components Coverage Δ
czicompress 66.75% <100.00%> (ø)
czishrink 80.63% <ø> (ø)

@m-ringler m-ringler requested a review from a team July 18, 2024 07:03
@m-ringler m-ringler self-assigned this Jul 18, 2024
@m-ringler m-ringler force-pushed the feature/dotnet-8.0.303 branch from 8df96c7 to ee0d475 Compare July 18, 2024 10:12
@m-ringler m-ringler force-pushed the feature/dotnet-8.0.303 branch from 6ffd807 to 39c8a55 Compare July 18, 2024 10:35
@m-ringler m-ringler force-pushed the feature/dotnet-8.0.303 branch from 64127a8 to 910548c Compare July 18, 2024 12:36
@m-ringler m-ringler force-pushed the feature/dotnet-8.0.303 branch from 21b229f to 2934653 Compare July 18, 2024 13:16
@m-ringler m-ringler force-pushed the feature/dotnet-8.0.303 branch from 90186ff to c7d42c4 Compare July 18, 2024 13:38
Copy link
Contributor

@ptahmose ptahmose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the ".vscode"-files are added on purpose? Or - you explained it in the description, so I assume this is correct.

LGTM, thanks!

Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you very much :)

@m-ringler m-ringler merged commit 35c5c16 into main Jul 19, 2024
19 checks passed
@ptahmose ptahmose deleted the feature/dotnet-8.0.303 branch July 19, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD cla Contributor License Agreement sent to Admin czishrink The issue or PR affects czishrink .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants