Add handling of cainfo property for cURL streams

[soyers]

STOP - Read this First!

Reporting a security vulnerability?
Check out the project's security policy.

Fill out and Adjust this Template

Description

Add a flag to the StreamProperties that allows setting the CURLOPT_CAINFO option for cURL based streams to a custom location.
The reason for this is that libczi is being consumed by pylibCZIrw and built for multiple different platforms that have their certificates storead at different locations. As a result, it's necessary to determine the location of the certificate bundle at runtime instead of build time.

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

This functionality is going to be used in an upcoming release of pylibCZIrw and will be tested there (either automatically or manually)

Checklist:

• I followed the Contributing Guidelines.
• I did a self-review.
• I commented my code, particularly in hard-to-understand areas.
• [] I updated the documentation.
• I updated the version of libCZI following Versioning of libCZI depending on the type of change
  • Bug fix -> PATCH
  • New feature -> MINOR
  • Breaking change -> MAJOR
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8cd30f6) 65.11% compared to head (9d9797b) 65.11%.

Files	Patch %	Lines
Src/libCZI/StreamsLib/curlhttpinputstream.cpp	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   65.11%   65.11%   -0.01%     
==========================================
  Files          81       81              
  Lines       10470    10474       +4     
==========================================
+ Hits         6818     6820       +2     
- Misses       3652     3654       +2     

Flag	Coverage Δ
windows-latest	65.11% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ptahmose]

Ja, something like that, LGTM. I wonder

• whether we should also add CURLOPT_CAINFO_BLOB while we are at it
• or - maybe add "all libcurl-options"?
• we should have a way to query whether it is necessary to set this piece of information
• if this should better be made a "one-time initialization" (e.g. "moved into https://github.com/ZEISS/libczi/blob/8cd30f6c74e71b2eb63f6284536ddb41d4f9d797/Src/libCZI/libCZI_StreamsLib.h#L246C9-L246C34 )?
• the new option should also be added here ->

  libczi/Src/CZICmd/cmdlineoptions.cpp

  Line 2187 in 8cd30f6

  kKeyStringToId[] =

But - this can wait for a later PR I guess.

Could you add a short note here -> https://github.com/ZEISS/libczi/blob/main/Src/libCZI/Doc/version-history.markdown , then it would be "fine for now for me".

[ptahmose]

Please consider renaming the enum to 'kCurlHttp_CaInfo' and adding a note to the version-history.

[ptahmose]

I'd guess this should be named "kCurlHttp_CaInfo" to follow the convention used by the other enum-values.

[DaveyJonesBitPail]

• whether we should also add CURLOPT_CAINFO_BLOB while we are at it

I think this would fit well into the scope of the PR, sometimes I may have a whole bundle based on the IT of my organization rather than a specific file.

or - maybe add "all libcurl-options"?

A pass-through here may make sense, but I think we will only ever use a subset.

if this should better be made a "one-time initialization"

Yes, absolutely!

Perhaps not within the scope of this PR but I think that it would be reasonable to add the option of setting CURLOPT_SSL_VERIFYPEER even if it's the "brute-force" fix

[ptahmose]

Please check #82 - where I tried to extend on this PR. This is supposed to supersede this PR.

[ptahmose]

This PR is superseded by #82 - the functionality from this PR is included with #82.