Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option "kCurlHttp_CaInfo" & "kCurlHttp_CaInfoBlob", allow to retrieve properties from a stream-class #82

Merged
merged 19 commits into from
Dec 4, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Dec 1, 2023

Description

This is following up on #81.

  • add options "kCurlHttp_CaInfo" & "kCurlHttp_CaInfoBlob" for the curl-based http-stream-class
  • add functionality to query (class-specific) properties from a stream-class (intended to be used to query compile-time options)
  • (fixed some issues when compiling unittests/CZICmd with GCC8.3 from manylinux2010-container)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

locally, manually and the functionality is going to be used in an upcoming release of pylibCZIrw and will be tested there (either automatically or manually)

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (8cd30f6) 65.11% compared to head (97d8198) 65.07%.

Files Patch % Lines
Src/libCZI/StreamsLib/curlhttpinputstream.cpp 55.55% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   65.11%   65.07%   -0.05%     
==========================================
  Files          81       81              
  Lines       10470    10511      +41     
==========================================
+ Hits         6818     6840      +22     
- Misses       3652     3671      +19     
Flag Coverage Δ
windows-latest 65.07% <63.63%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptahmose ptahmose requested review from DaveyJonesBitPail and a team December 1, 2023 19:39
@ptahmose ptahmose added the cla Contributor License Agreement sent to Admin label Dec 1, 2023
Copy link
Contributor

@DaveyJonesBitPail DaveyJonesBitPail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We may want to add some test cases in the future based on codecov reports.

@ptahmose ptahmose merged commit 9092aea into ZEISS:main Dec 4, 2023
15 checks passed
@ptahmose ptahmose deleted the jbl/ca_cert branch December 4, 2023 13:39
@ptahmose ptahmose mentioned this pull request Dec 4, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants