fix: createdb failure + implement get_all_entries
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Schleich
changed the title
createdb failure + implement get_all_entries
JEnoch
requested changes
Jun 13, 2024
v2/src/lib.rs
Outdated
| @@ -611,7 +625,7 @@ impl Storage for InfluxDbStorage { | |||
| |> filter(fn: (r) => r._measurement == \"{}\") | |||
There was a problem hiding this comment.
I think the strict equality won't work in case the queried keyexpr contains * or **.
With InfluxDB v1 the keyexpr is converted to an InfluxQL regular epxression here and this regex is used in the query, instead of the keyexpr.
The same shall be done for v2, using Flux regular expressions in fliter predicate.
There was a problem hiding this comment.
I have implemented mapping Key Expressions with Wildcards to regular expressions.
However i've upon testing, ive found running z_get.py, the get() function is called individually with each Key Expr output from get_all
@JEnoch
Is there a way to call this such that the get gets called with a wildcard KeyExpr ?
…-bot/sync-toolchain Sync Rust toolchain
* build: Sync with eclipse-zenoh/zenoh@25f06bd from 2024-05-21 (eclipse-zenoh#119) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@3118d31 from 2024-05-28 (eclipse-zenoh#120) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@009f666 from 2024-05-30 (eclipse-zenoh#122) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@d574654 from 2024-06-03 (eclipse-zenoh#123) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@c279982 from 2024-06-05 (eclipse-zenoh#124) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@d8e66de from 2024-06-10 (eclipse-zenoh#125) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@9d09742 from 2024-06-11 (eclipse-zenoh#126) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@ed6c636 from 2024-06-12 (eclipse-zenoh#127) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Update v1 to use zenoh v1.0.0 * Update V2 to use zenoh v1.0.0 * fmt * Remove internal zenoh Crates from dependencies * plugins in Cargo.Toml * Cleanup * remove TODO, add comments * Use New API for deserializing payload --------- Co-authored-by: eclipse-zenoh-bot <[email protected]> Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#138) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#139) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#140) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#141) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#142) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#143) Co-authored-by: eclipse-zenoh-bot <[email protected]>
* chore: bump zenoh version * chore: update branch
…-zenoh#148) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#153) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#154) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#155) Co-authored-by: eclipse-zenoh-bot <[email protected]>
…-zenoh#156) Co-authored-by: eclipse-zenoh-bot <[email protected]>
|
Bumped the influxdb2 version after a new release including the json header fixes: |
|
Please Refer to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:
createdbnot functioning due to missingapplication/jsonheader in requestimplement:
get_all_entriesfunction ofStorageTrait forInfluxDbStorageAlso there are logic + safety + code quality improvements (happy to discuss this) in this PR.
NOTE:
This is using a fork of the influxDB2 library here
Charles-Schleich/influxdb2
I have an open PR to merge my fix into the library on Crates.io
aprimadi/influxdb2#61
If this is blocking release,
then it makes sense to fork the influxdb2 library into the zettascale workspace, and publish a Zettascale maintained version on crates.io
I did not treat this as a refactor, however this could use a minor refactor.
It makes sense for next release.