Fix/createdb #162

Charles-Schleich · 2024-07-23T14:49:39Z

New PR pointing to correct branch.
fix: createdb not functioning due to missing application/json header in request
implement: get_all_entries function of Storage Trait for InfluxDbStorage

Also there are logic + safety + code quality improvements (happy to discuss this) in this PR.
Note:
I did not treat this as a refactor, however this could use a minor refactor.
It makes sense for next release.

Old PR:
ZettaScaleLabs#4

…-zenoh#119) Co-authored-by: eclipse-zenoh-bot <[email protected]>

…-zenoh#120) Co-authored-by: eclipse-zenoh-bot <[email protected]>

…-zenoh#122) Co-authored-by: eclipse-zenoh-bot <[email protected]>

…-zenoh#123) Co-authored-by: eclipse-zenoh-bot <[email protected]>

…-zenoh#124) Co-authored-by: eclipse-zenoh-bot <[email protected]>

…-zenoh#125) Co-authored-by: eclipse-zenoh-bot <[email protected]>

…-zenoh#126) Co-authored-by: eclipse-zenoh-bot <[email protected]>

…-zenoh#127) Co-authored-by: eclipse-zenoh-bot <[email protected]>

…on support

J-Loudet

Only minor changes

J-Loudet · 2024-07-25T09:14:49Z

v1/src/lib.rs

@@ -527,7 +527,7 @@ impl Storage for InfluxDbStorage {
            base64: bool,
            value: String,
        }
-        debug!("Get {:?} with Influx query: {}", key, influx_query_str);
+        // debug!("Get {:?} with Influx query: {}", &key, influx_query_str);


I would either remove the line if the debug log is unneeded, or de-comment it

Why not remove it?

It has no place in this code any longer. Gone it is.

v2/src/lib.rs

… db_name code, plugin wont start without db_name

J-Loudet

LGTM

J-Loudet · 2024-07-30T14:57:24Z

v1/src/lib.rs

@@ -527,7 +527,7 @@ impl Storage for InfluxDbStorage {
            base64: bool,
            value: String,
        }
-        debug!("Get {:?} with Influx query: {}", key, influx_query_str);
+        // debug!("Get {:?} with Influx query: {}", &key, influx_query_str);


Why not remove it?

* chore: Sync Rust toolchain * Update influxdb to use Zenoh 1.0.0 (#130) * build: Sync with eclipse-zenoh/zenoh@25f06bd from 2024-05-21 (#119) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@3118d31 from 2024-05-28 (#120) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@009f666 from 2024-05-30 (#122) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@d574654 from 2024-06-03 (#123) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@c279982 from 2024-06-05 (#124) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@d8e66de from 2024-06-10 (#125) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@9d09742 from 2024-06-11 (#126) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@ed6c636 from 2024-06-12 (#127) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Update v1 to use zenoh v1.0.0 * Update V2 to use zenoh v1.0.0 * fmt * Remove internal zenoh Crates from dependencies * plugins in Cargo.Toml * Cleanup * remove TODO, add comments * Use New API for deserializing payload --------- Co-authored-by: eclipse-zenoh-bot <[email protected]> Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@65e5df7 from 2024-06-21 (#138) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@a6d117b from 2024-06-21 (#139) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@2b16fed from 2024-06-25 (#140) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@e1beef1 from 2024-06-25 (#141) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@fc18f90 from 2024-06-26 (#142) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@1790d59 from 2024-06-26 (#143) Co-authored-by: eclipse-zenoh-bot <[email protected]> * chore: bump zenoh version (#144) * chore: bump zenoh version * chore: update branch * build: Sync with eclipse-zenoh/zenoh@e021d0d from 2024-07-03 (#148) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@54d12e1 from 2024-07-05 (#153) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@c7e418f from 2024-07-05 (#154) Co-authored-by: eclipse-zenoh-bot <[email protected]> * remove timestamp generation for unimplemented function (#150) * build: Sync with eclipse-zenoh/zenoh@cae8697 from 2024-07-05 (#155) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@6df74c7 from 2024-07-07 (#156) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@12b11ee from 2024-07-08 (#157) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@9e1c4a8 from 2024-07-08 (#159) Co-authored-by: eclipse-zenoh-bot <[email protected]> * chore: Sync Rust toolchain * chore: Sync Rust toolchain * build: Sync with eclipse-zenoh/zenoh@4827f39 from 2024-07-24 (#163) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@0c43c08 from 2024-07-25 (#166) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@32bdded from 2024-07-26 (#167) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Update README: remove leading `/` - new key format * build: Sync with eclipse-zenoh/zenoh@502d3be from 2024-07-30 (#172) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Fix/createdb (#162) fix: createdb not functioning due to missing application/json header in request implement: get_all_entries function of Storage Trait for InfluxDbStorage Also there are logic + safety + code quality improvements * build: Sync with eclipse-zenoh/zenoh@5d09cf7 from 2024-08-01 (#174) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Merge main into dev/1.0.0 (#175) * Update README: remove leading `/` - new key format * Merge branch main into dev/1.0.0 --------- Co-authored-by: zettascale-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@b1e4dba from 2024-08-05 (#178) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@b7d42ef from 2024-08-06 (#179) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Migrate from async-std to tokio (#169) * Migrate from async-std to tokio Signed-off-by: ChenYing Kuo <[email protected]> * Support reusing Runtime if possible. Signed-off-by: ChenYing Kuo <[email protected]> --------- Signed-off-by: ChenYing Kuo <[email protected]> * build: Sync with eclipse-zenoh/zenoh@2d5ab7c from 2024-08-06 (#180) Co-authored-by: eclipse-zenoh-bot <[email protected]> * chore: remove build-resources dir and Cargo.lock (#181) Cargo.lock file wrongly added by the sync lock file workflow. * build: Sync with eclipse-zenoh/zenoh@0e2f78a from 2024-08-14 (#185) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Bump dev version to `1.0.0-dev` (#186) * chore: Bump version to `1.0.0-dev` * chore: Bump /zenoh.*/ dependencies to `1.0.0-dev` * chore: Update Cargo lockfile --------- Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@8b027e9 from 2024-08-22 (#187) Co-authored-by: eclipse-zenoh-bot <[email protected]> * WIP: fix no reactor running when executing task, Dynamic plugin * Add handle check inside show_databases * replace TimedMeasurementDrop with Tokio timeout, Add await_task! to use Plugin Runtime for dyn plugins * remove client clones * replace blocking with task spawn, v1 * remove debug + format * remove return result: schedule measurement drop * remove macro, add comment regarding tokio runtime * Add await_task macro, fix get() call * build: Sync with eclipse-zenoh/zenoh@7f7d648 from 2024-08-28 (#191) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Wrap Client in Arc, Cleanup * replace timeout with sleep * build: Sync with eclipse-zenoh/zenoh@3579f12 from 2024-08-29 (#193) Co-authored-by: eclipse-zenoh-bot <[email protected]> * build: Sync with eclipse-zenoh/zenoh@926208c from 2024-08-29 (#196) Co-authored-by: eclipse-zenoh-bot <[email protected]> * Point to eclipse-zenoh/zenoh branch=main --------- Signed-off-by: ChenYing Kuo <[email protected]> Co-authored-by: eclipse-zenoh-bot <[email protected]> Co-authored-by: eclipse-zenoh-bot <[email protected]> Co-authored-by: C Schleich <[email protected]> Co-authored-by: Joseph Perez <[email protected]> Co-authored-by: zettascale-bot <[email protected]> Co-authored-by: ChenYing Kuo (CY) <[email protected]> Co-authored-by: Diogo Matsubara <[email protected]> Co-authored-by: Michael Ilyin <[email protected]>

eclipse-zenoh-bot and others added 16 commits May 22, 2024 00:15

build: Sync with eclipse-zenoh/zenoh@25f06bd from 2024-05-21 (eclipse…

b214c10

…-zenoh#119) Co-authored-by: eclipse-zenoh-bot <[email protected]>

fix: createdb not functioning due to application/json header in request

fc46db4

build: Sync with eclipse-zenoh/zenoh@3118d31 from 2024-05-28 (eclipse…

a2521ec

…-zenoh#120) Co-authored-by: eclipse-zenoh-bot <[email protected]>

fix: Createdb + implemen get_all_entries

aa57f57

fix: fmt

a98e50b

build: Sync with eclipse-zenoh/zenoh@009f666 from 2024-05-30 (eclipse…

d093bc1

…-zenoh#122) Co-authored-by: eclipse-zenoh-bot <[email protected]>

fix: createdb + impl get_all_queries, cleanup

5a51995

build: Sync with eclipse-zenoh/zenoh@d574654 from 2024-06-03 (eclipse…

ca5409e

…-zenoh#123) Co-authored-by: eclipse-zenoh-bot <[email protected]>

build: Sync with eclipse-zenoh/zenoh@c279982 from 2024-06-05 (eclipse…

063b579

…-zenoh#124) Co-authored-by: eclipse-zenoh-bot <[email protected]>

build: Sync with eclipse-zenoh/zenoh@d8e66de from 2024-06-10 (eclipse…

fdf5720

…-zenoh#125) Co-authored-by: eclipse-zenoh-bot <[email protected]>

build: Sync with eclipse-zenoh/zenoh@9d09742 from 2024-06-11 (eclipse…

9d8a353

…-zenoh#126) Co-authored-by: eclipse-zenoh-bot <[email protected]>

build: Sync with eclipse-zenoh/zenoh@ed6c636 from 2024-06-12 (eclipse…

bedc328

…-zenoh#127) Co-authored-by: eclipse-zenoh-bot <[email protected]>

Merge updated Cargo.lock

1626e58

Merge dev/1.0.0 -> fix/createdb

64936ee

cleanup old comments, small refactor, fix empty query string bug

9a036b2

Cleanup, re-write get to build up query, include wildcard keyexpressi…

fce2f35

…on support

Charles-Schleich marked this pull request as draft July 23, 2024 14:52

Charles-Schleich marked this pull request as ready for review July 23, 2024 14:52

Charles-Schleich mentioned this pull request Jul 23, 2024

fix: createdb failure + implement get_all_entries ZettaScaleLabs/zenoh-backend-influxdb#4

Closed

Mallets requested a review from J-Loudet July 25, 2024 09:09

J-Loudet requested changes Jul 25, 2024

View reviewed changes

cleanup, add lazy execution if no KeyExpr in function calls, refactor…

2090f85

… db_name code, plugin wont start without db_name

Charles-Schleich requested a review from J-Loudet July 30, 2024 13:22

J-Loudet approved these changes Jul 30, 2024

View reviewed changes

remove debug

679787c

J-Loudet merged commit ba65e90 into eclipse-zenoh:dev/1.0.0 Jul 30, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/createdb #162

Fix/createdb #162

Charles-Schleich commented Jul 23, 2024 •

edited

Loading

J-Loudet left a comment

J-Loudet Jul 25, 2024

J-Loudet Jul 30, 2024

Charles-Schleich Jul 30, 2024

J-Loudet left a comment

J-Loudet Jul 30, 2024

Fix/createdb #162

Fix/createdb #162

Conversation

Charles-Schleich commented Jul 23, 2024 • edited Loading

J-Loudet left a comment

Choose a reason for hiding this comment

J-Loudet Jul 25, 2024

Choose a reason for hiding this comment

J-Loudet Jul 30, 2024

Choose a reason for hiding this comment

Charles-Schleich Jul 30, 2024

Choose a reason for hiding this comment

J-Loudet left a comment

Choose a reason for hiding this comment

J-Loudet Jul 30, 2024

Choose a reason for hiding this comment

Charles-Schleich commented Jul 23, 2024 •

edited

Loading