-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POSIX implementation of ExpandPath #36
Merged
emmanuelm41
merged 6 commits into
Zondax:main
from
alessio:ABI-back-compat-ExpandPath-POSIX-impl
Apr 29, 2024
Merged
POSIX implementation of ExpandPath #36
emmanuelm41
merged 6 commits into
Zondax:main
from
alessio:ABI-back-compat-ExpandPath-POSIX-impl
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function ExpandPath does not implement the tilde expansion as mandated by POSIX, i.e. a tilde-prefix could be followed by a valid login name; in that case, the tilde-prefix shall be replaced by the home directory associated with that login name. See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html for more information.
bizk
reviewed
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me
lucaslopezf
approved these changes
Dec 24, 2023
@alessio could you please sign the CLA so that I can merge the PR? |
@alessio just pinging you again! I want to merge this, but I need the CLA signed. Could you please do it? Thanks! |
emmanuelm41
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function ExpandPath does not implement the tilde expansion as mandated by POSIX, i.e. a tilde-prefix could be followed by a valid login name; in that case, the tilde-prefix shall be replaced by the home directory associated with that login name.
See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html for more information.
🔗 zboto Link