Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIX implementation of ExpandPath #36

Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Dec 14, 2023

The function ExpandPath does not implement the tilde expansion as mandated by POSIX, i.e. a tilde-prefix could be followed by a valid login name; in that case, the tilde-prefix shall be replaced by the home directory associated with that login name.

See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html for more information.

🔗 zboto Link

The function ExpandPath does not implement the tilde
expansion as mandated by POSIX, i.e. a tilde-prefix
could be followed by a valid login name; in that case,
the tilde-prefix shall be replaced by the home directory
associated with that login name.

See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html
for more information.
@alessio
Copy link
Contributor Author

alessio commented Dec 14, 2023

@jleni @bizk please review

Copy link
Contributor

@bizk bizk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2024

CLA assistant check
All committers have signed the CLA.

@emmanuelm41
Copy link
Member

@alessio could you please sign the CLA so that I can merge the PR?

@emmanuelm41
Copy link
Member

@alessio just pinging you again! I want to merge this, but I need the CLA signed. Could you please do it? Thanks!

@emmanuelm41 emmanuelm41 merged commit d377ec9 into Zondax:main Apr 29, 2024
2 checks passed
@alessio alessio deleted the ABI-back-compat-ExpandPath-POSIX-impl branch May 25, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants