Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A replay protection bug was discovered in Namada (see anoma/namada#1867 ) and its resolution (to be included in v0.24.0) involves a conceptually minor change to the transaction signing process. Essentially the inner transaction signature now signs over the raw header hash where it formerly used to sign over the data section hash and the code section hash. The transaction format does not change at all.
This PR is one possible way to implement these changes on the hardware wallet. The actual changes are all in the last commit (117f548). Specifically, the changes are as follows:
0xFF
referring to the raw headertransactions.test.ts
tests to supply the raw header hash (in addition to the header hash)