Heather M SeaTurtles js-adagrams #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jun 14, 2022
| Y: 2, | ||
| Z: 1, | ||
| }; | ||
|
|
||
| export const drawLetters = () => { |
There was a problem hiding this comment.
this is a good approach! During our review, we also saw someone use a spread operator. A few different ways to do it! You can also go ahead and remove the commented code to clean it up.
| // lettersInHand is an array of letters. | ||
| // this seems a bit long. Maybe I can use another method to count letter in ... | ||
| // or maybe I can make another function to do this. | ||
| const lettersArray = lettersInHand; |
There was a problem hiding this comment.
I know you were thinking of another way to do this. Here is one way to do it with one for loop
export const usesAvailableLetters = (input, lettersInHand) => {
const input_array = input.split("");
const n = input.length;
let lettersInHandCopy = [...lettersInHand];
for (let i = 0; i < n; i++) {
let letter = input_array[i];
if (lettersInHandCopy.includes(letter)) {
let j = lettersInHandCopy.indexOf(letter);
lettersInHandCopy.splice(j, 1);
} else {
return false;
}
}
return true;
};
Comment on lines
+128
to
+130
| if (word.length > 6) { | ||
| score += 8; | ||
| } |
There was a problem hiding this comment.
you could also use a ternary here and would look like
let score = word.length >= 6 ? 8 : 0;| return score; | ||
| }; | ||
|
|
||
| export const getIndexTieBreak = (highestScoringWords) => { |
| highestIndex = i; | ||
| } | ||
| } | ||
| return highestIndex; | ||
| }; | ||
|
|
||
| export const highestScoreFrom = (words) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.