update pull request #99
Conversation
| <br></a> | ||
| <br></a> | ||
| <br></a> |
There was a problem hiding this comment.
I don't think you need these closing a tags. If you want to add a break you can just have <br>
|
|
||
| </section> | ||
| <section id="about"> | ||
| <div> |
There was a problem hiding this comment.
There is nothing wrong with using div but we want to use semantic html when we can. Because you already have a section tag you don't need this div tag. You can just have
<section>
<h1>
<p>
....
| </section> | ||
|
|
||
| <section id="portfolio"> | ||
| <div> |
| background-color: #14FFEC; | ||
| } | ||
|
|
||
| #portfolio { |
There was a problem hiding this comment.
portfolio and home have the same background color. You can do #home, #portfolio {....}
| /* .gallery { | ||
| background: #EEE; | ||
| } */ |
| <li><a href="#home" class="active">home</a></li> | ||
| <li><a href="#about">about me</a></li> | ||
| <li><a href="#portfolio">porfolio</a></li> | ||
| <li><a href="SanRSWEResume.html">resume</a></li> |
There was a problem hiding this comment.
You can add target="_blank" to your a tag and it will open your resume in a new tab so the user can stay on your website.
| @@ -0,0 +1,62 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
move your index.html and resume to your pages directory. You should also move your emoji into your assets directory and your styles.css into a styles directory. This will keep everything organized.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions