Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pull request #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions SanRSWEResume.html

Large diffs are not rendered by default.

Binary file removed assets/personal-portfolio_wireframe1.png
Binary file not shown.
Binary file removed assets/personal-portfolio_wireframe2.png
Binary file not shown.
Binary file added emojiii-removebg-preview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
62 changes: 62 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
<!DOCTYPE html>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move your index.html and resume to your pages directory. You should also move your emoji into your assets directory and your styles.css into a styles directory. This will keep everything organized.

<html lang="en">
<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="styles.css">
<script src="https://unpkg.com/flickity@2/dist/flickity.pkgd.min.js"></script>

<title>
San's Portfolio
</title>
</head>
<body>

<section id="home">
<header>
<a href="#" class="logo">SAN ROBINSON</a>
<ul id="menu">
<li><a href="#home" class="active">home</a></li>
<li><a href="#about">about me</a></li>
<li><a href="#portfolio">porfolio</a></li>
<li><a href="SanRSWEResume.html">resume</a></li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add target="_blank" to your a tag and it will open your resume in a new tab so the user can stay on your website.

</ul>
</header>

<center><h1><a href="https://github.com/saanish3" id="btn">explore my git</a></h1></center>
<br></a>
<br></a>
<br></a>
Comment on lines +28 to +30
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need these closing a tags. If you want to add a break you can just have <br>

<center><img src=emojiii-removebg-preview.png alt = "reddit avatar"> </center>


</section>
<section id="about">
<div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing wrong with using div but we want to use semantic html when we can. Because you already have a section tag you don't need this div tag. You can just have

<section>
<h1>
<p>
....

<h1 class="logo">about me</h1>
<p>Strategic leader and project/program manager, with over 3 years of experience in leading/delivering projects,
workforce management, process improvement, business solutions, and strategic communications. Adept at conducting
gap analyses, as well as utilizing project management principles for process improvement purposes, which result
in optimized productivity and significant organizational cost-savings. Demonstrated ability to expertly collaborate
across functions to manage projects and portfolios and budgets, ensuring all projects remain within scope and under
projected costs. Future Software Engineer.
</p>
</div>

</section>

<section id="portfolio">
<div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here you don't need this div

<h1>portfolio</h1>
<p> Task List API - Made web API to organize our tasks, using REST API and Postgres SQL to create, read, update, and delete tasks. <a
href="https://github.com/saanish3/task-list-api">Find the GitHub repo here.<br></a>
<br></a>
Solar System API - Collaborately built a Solar System API. This API stores information about different planets using RESTful endpoints for CRUD operations. <a
href="https://github.com/saanish3/tyrah-and-san-solar-system-api/blob/main/README.md"> GitHub repo here
</a>.</p>
</div>
</section>

</body>
</html>
12 changes: 0 additions & 12 deletions pages/about.html

This file was deleted.

12 changes: 0 additions & 12 deletions pages/index.html

This file was deleted.

12 changes: 0 additions & 12 deletions pages/portfolio.html

This file was deleted.

177 changes: 177 additions & 0 deletions styles.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,177 @@
@import url('https://fonts.googleapis.com/css2?family=Roboto:ital,wght@1,100&display=swap');
flickity.css
*
{
margin:0;
padding:0;
box-sizing: border-box;
font-family: 'Roboto', sans-serif;
}
html{
scroll-behavior: smooth;
}

body

{
margin: 0;
width: 100vw;
height: 100vh;
min-height: 20vh;
background:linear-gradient(#0b0c10,#1f2833);
}


div, section, span, ul, li, a, header{
box-sizing: border-box;
}


header

{
position: relative;
width: 100%;
padding: 10px 10px;
display: flex;
justify-content: space-between;
align-items: center;
z-index: 999;
}

header .logo
{
color:whitesmoke;
font-weight: 700;
text-decoration: none;
font-size: 2em;
text-transform: uppercase;
letter-spacing: 2px;
}



#menu li {
list-style: none;
display: inline-block;
margin: 20px;
}

#menu li a{
color:#0b0c10;
text-decoration: none;
font-size: 20px;
}


section
{
position: relative;
width: 100%;
height: 100vh;
float: left;
}

#home {
background-color: #212121;
}

#about {
background-color: #14FFEC;
}

#portfolio {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

portfolio and home have the same background color. You can do #home, #portfolio {....}

background-color: #212121;
}

#SanRSWEResume.html {
background-color:#14FFEC;
}

h1{
position: absolute;
top: 7%;
left: 50%;
transform: translate(-50%, 50%);
color: #ffff;
}

#btn
{
text-decoration: none;
display: inline-block;
padding: 8px 30px;
border-radius: 40px;
background: #14FFEC;
color: whitesmoke;
font-size: 1.5em;
transform: translateY(100px);
}

header .ul
{
display: flex;
justify-content: center;
align-items: center;
}
header ul li
{
list-style: none;
margin-left: 20px;
}

header ul li a
{
text-decoration: none;
padding: 6px 15px;
color: #c5c6c7;
border-radius: 20px;
}
header ul li a:hover,
header ul li a.active
{
background:#14FFEC;
color: #323232;
}

p{
font-size: x-large;
text-align:center;
padding: 8px 30px;
position: absolute;
top: 7%;
left: 50%;
transform: translate(-50%, 50%);
color: #ffff;
}


* {
-webkit-box-sizing: border-box;
box-sizing: border-box;
}

body { font-family: sans-serif; }

/* .gallery {
background: #EEE;
} */
Comment on lines +156 to +158
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this


.gallery-cell {
width: 66%;
height: 200px;
margin-right: 10px;
background: #8C8;
counter-increment: gallery-cell;
}

/* cell number */
.gallery-cell:before {
display: block;
text-align: center;
content: counter(gallery-cell);
line-height: 200px;
font-size: 80px;
color: white;
}