Fix json output when a bundle does not use submodules #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bundles, such as circuitpython-fonts, don't use submodules to contain their individual libraries. Change build_bundle_json so that it works correctly if multiple libraries come from the same submodule. With this change, the generated metadata for circuitpython-fonts contains an entry for every font, not just for one font.
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bundles, such as circuitpython-fonts, don't use submodules to contain their individual libraries.
Change build_bundle_json so that it works correctly if multiple libraries come from the same submodule.
With this change, the generated metadata for circuitpython-fonts contains an entry for every font, not just for one font.
I spot checked the result on the main bundle and it looks sane as well.
@Neradoc I don't know all the reasons that you rolled your own build script for https://github.com/Neradoc/Circuitpython_Keyboard_Layouts but I'm guessing this might have been one of them. Do you have any interest in figuring out what else would need to change to allow you to use circuitpython-build-bundles as well?