Skip to content

Fix bugs in IDTA-01001-3-0-1 schemas #621

Fix bugs in IDTA-01001-3-0-1 schemas

Fix bugs in IDTA-01001-3-0-1 schemas #621

Triggered via pull request October 30, 2024 12:32
Status Failure
Total duration 23s
Artifacts
Check-title-and-description-of-pull-request
11s
Check-title-and-description-of-pull-request
Fit to window
Zoom out
Zoom in

Annotations

1 error and 2 warnings
Check-title-and-description-of-pull-request
The message 1 is invalid: * The line 3 of the message (line 1 of the body) exceeds the limit of 72 characters. The line contains 93 characters: "This fixes bugs found in schema files in preparation of a v3.0.9 release of the schema files:". Please reformat the body so that all the lines fit 72 characters. The original message was: Fix bugs in IDTA-01001-3-0-1 schemas This fixes bugs found in schema files in preparation of a v3.0.9 release of the schema files: # Fix order of EmbeddedDataSpecification attributes Previously, the order of the attributes in class `EmbeddedDataSpecification` got mixed up, making the schemas of Release 3.0.8 not backward compatible, as found out in #477. This reverts the change of the order of attributes back to the state of v3.0, so that the schemas are properly backward compatible. Fixes #477 # SHACL Make SHACL regex patterns follow JSON Schema ones We included the regex pattern as-is from the input which caused problems with the regex engines as the patterns in the meta-model are written in a Python dialect (and assuming that the regex engine works on UTF-32 characters). However, most regex engines in the wild operating on SHACL (*e.g.*, Java SHACL validators) use UTF-16 to represent the text and do not support some parts of the Python regex dialect. For example, in the input meta-model specification, we omit the minimum bound 0 (*e.g.*, ``{,4}``), which breaks with the Java regex engine beneath the SHACL validator. Instead, with this patch, we parse the pattern from the specification and re-render it into the form that we also use in JSON Schema. We pick JSON Schema regex dialect as most SHACL validators in the wild can deal with it, in particular those based on Java as a platform. Hence, we decide to serve this user base with priority. Discovered in [aas-core-meta issue 342]. Fixed in [aas-core-codegen commit e22cc]. [aas-core-meta issue 342]: aas-core-works/aas-core-meta#342 [aas-core-codegen commit e22cc]: aas-core-works/aas-core-codegen@e22ccae # XSD Adapt XML Schema for some schema validators Previously we did not define `aas:environment` directly via an `xs:element` tag, rather only provided it directly as `xs:complexType`. This created issues with several XML Schema validator engines. Fixes #457. Lastly, we also update the generated examples.
Check-title-and-description-of-pull-request
The following actions uses node12 which is deprecated and will be forced to run on node16: mristin/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Check-title-and-description-of-pull-request
The following actions use a deprecated Node.js version and will be forced to run on node20: mristin/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/