Fix bugs in IDTA-01001-3-0-1 schemas #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We included the regex pattern as-is from the input which caused problems
with the regex engines as the patterns in the meta-model are written in
a Python dialect (and assuming that the regex engine works on UTF-32
characters). However, most regex engines in the wild operating on SHACL
(*e.g.*, Java SHACL validators) use UTF-16 to represent the text and do
not support some parts of the Python regex dialect. For example, in
the input meta-model specification, we omit the minimum bound 0
(*e.g.*, ``{,4}``), which breaks with the Java regex engine beneath
the SHACL validator.
Instead, with this patch, we parse the pattern from the specification
and re-render it into the form that we also use in JSON Schema. We pick
JSON Schema regex dialect as most SHACL validators in the wild can deal
with it, in particular those based on Java as a platform. Hence, we
decide to serve this user base with priority.
Discovered in [aas-core-meta issue 342].
Fixed in [aas-core-codegen commit e22cc].
[aas-core-meta issue 342]: aas-core-works/aas-core-meta#342
[aas-core-codegen commit e22cc]: aas-core-works/aas-core-codegen@e22ccae
Previously we did not define `aas:environment` directly via an `xs:element` tag, rather only provided it directly as `xs:complexType`. This created issues with several XML Schema validator engines. This commit fixes this problem, discovered in #457.
s-heppner
changed the title
s-heppner
added a commit
to s-heppner/aas-core-schemagen
that referenced
this pull request
Aug 30, 2024
See admin-shell-io/aas-specs#464 for details
BirgitBoss
approved these changes
Oct 25, 2024
|
Please update README.md#releases after making an updated release |
|
see bug issue: #477 |
BirgitBoss
requested changes
Oct 27, 2024
Previously, the order of the attributes in class `EmbeddedDataSpecification` got mixed up, making the schemas of Release 3.0.8 not backward compatible, as found out in #477. This reverts the change of the order of attributes back to the state of v3.0, so that the schemas are properly backward compatible. Fixes #477
s-heppner
changed the title
|
The |
BirgitBoss
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bugs found in schema files in preparation of a v3.0.9 release of the schema files:
Fix order of EmbeddedDataSpecification attributes
Previously, the order of the attributes in class
EmbeddedDataSpecificationgot mixed up, makingthe schemas of Release 3.0.8 not backward
compatible, as found out in #477.
This reverts the change of the order of attributes
back to the state of v3.0, so that the schemas are
properly backward compatible.
Fixes #477
SHACL
Make SHACL regex patterns follow JSON Schema ones
We included the regex pattern as-is from the
input which caused problems with the
regex engines as the patterns in the meta-model
are written in a Python dialect
(and assuming that the regex engine works on
UTF-32 characters). However, most regex engines
in the wild operating on SHACL
(e.g., Java SHACL validators) use UTF-16
to represent the text and do not support
some parts of the Python regex dialect.
For example, in the input meta-model
specification, we omit the minimum bound 0
(e.g.,
{,4}), which breaks with the Javaregex engine beneath the SHACL validator.
Instead, with this patch, we parse the pattern
from the specification and re-render it into the
form that we also use in JSON Schema. We pick
JSON Schema regex dialect as most
SHACL validators in the wild can deal with it,
in particular those based on Java as a platform.
Hence, we decide to serve this
user base with priority.
Discovered in aas-core-meta issue 342.
Fixed in aas-core-codegen commit e22cc.
XSD
Adapt XML Schema for some schema validators
Previously we did not define
aas:environmentdirectly via an
xs:elementtag, rather onlyprovided it directly as
xs:complexType.This created issues with several XML Schema
validator engines.
Fixes #457.
Lastly, we also update the generated examples.