Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in IDTA-01001-3-0-1 schemas #464

Merged
merged 4 commits into from
Nov 15, 2024

Commits on Aug 30, 2024

  1. Make SHACL regex patterns follow JSON Schema ones

    We included the regex pattern as-is from the input which caused problems
    with the regex engines as the patterns in the meta-model are written in
    a Python dialect (and assuming that the regex engine works on UTF-32
    characters). However, most regex engines in the wild operating on SHACL
    (*e.g.*, Java SHACL validators) use UTF-16 to represent the text and do
    not support some parts of the Python regex dialect. For example, in
    the input meta-model specification, we omit the minimum bound 0
    (*e.g.*, ``{,4}``), which breaks with the Java regex engine beneath
    the SHACL validator.
    
    Instead, with this patch, we parse the pattern from the specification
    and re-render it into the form that we also use in JSON Schema. We pick
    JSON Schema regex dialect as most SHACL validators in the wild can deal
    with it, in particular those based on Java as a platform. Hence, we
    decide to serve this user base with priority.
    
    Discovered in [aas-core-meta issue 342].
    Fixed in [aas-core-codegen commit e22cc].
    
    [aas-core-meta issue 342]: aas-core-works/aas-core-meta#342
    [aas-core-codegen commit e22cc]: aas-core-works/aas-core-codegen@e22ccae
    s-heppner committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    a71640d View commit details
    Browse the repository at this point in the history
  2. Adapt XML Schema for some schema validators

    Previously we did not define `aas:environment`
    directly via an `xs:element` tag, rather only
    provided it directly as `xs:complexType`.
    This created issues with several XML Schema
    validator engines.
    
    This commit fixes this problem,
    discovered in #457.
    s-heppner committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c535469 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Fix order of EmbeddedDataSpecification attributes

    Previously, the order of the attributes in class
    `EmbeddedDataSpecification` got mixed up, making
    the schemas of Release 3.0.8 not backward
    compatible, as found out in #477.
    
    This reverts the change of the order of attributes
    back to the state of v3.0, so that the schemas are
    properly backward compatible.
    
    Fixes #477
    s-heppner committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    38119df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58dcbca View commit details
    Browse the repository at this point in the history