Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes #476

Merged
merged 16 commits into from
Oct 26, 2024
Merged

Minor changes #476

merged 16 commits into from
Oct 26, 2024

Conversation

BirgitBoss
Copy link
Collaborator

No description provided.

@BirgitBoss
add issues link
cd48cfa
@BirgitBoss
Formatting of "HasKind" inherited in Submodel
87cf326
@BirgitBoss
add example for deprecated attribute in class in Annex UML
b7438ab
@BirgitBoss
add xref to specifics
01ecccc
@BirgitBoss
Remove comparison with semanticId to no have unnecessary dependencies
feffda2
@BirgitBoss
provide invalid und valid examples consistently throughout chapter
717646d
@BirgitBoss
AutomationML and OPC UA Mapping is not part of IDTA-01001 any longer:
aaa1e5f 
remove comments on them
@BirgitBoss
provide valid examples that is often considers to be a bug
98698c7 
"isCaseOfs"
@BirgitBoss
correct copy/paste error
bc3999f 
(in former versions administration was inherited via "Identifiable"
@BirgitBoss
improvde descrition of Key/value:
4259f20 
may also be idShort or any other fragment value
+ add xref
@BirgitBoss
correct figure: Reference->Reference dependency is already part of re…
76bd0d8 
…ference.puml
@BirgitBoss
add missing text and link to Annex explaining different of templates,…
0c15380 
… qualifiers etc. added

to overview of structure of document
@BirgitBoss
correct xref link
42ec9cb
@BirgitBoss BirgitBoss requested a review from zrgt October 17, 2024 11:59
zrgt
zrgt reviewed Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@zrgt zrgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some new or changed xrefs had some bugs, which I have fixed and pushed the fix.
There are two open points that we should decide on. See comments

documentation/IDTA-01001/modules/ROOT/pages/spec-metamodel/submodel-elements.adoc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other occurrences in the spec? I have found 21 occurences of "I4.0 Component" in the docs.

Copy link
Collaborator Author

@BirgitBoss BirgitBoss Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, really but hopefully only in the Annex
https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/annex/concepts-aas.html
https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/annex/requirements.html
https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/annex/usage-metamodel.html#_composite_i4_0_components

Here it is more historic and would be ok. Only for Composite i4.0 components we need to rethink...

documentation/IDTA-01001/modules/ROOT/partials/diagrams/uml-basics/deprecated-attribute.puml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove numeration from other uml-basics PUML-files?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I was wrong, it is better without numbering

@BirgitBoss BirgitBoss merged commit ca4e492 into IDTA-01001-3-1_working Oct 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrgt zrgt zrgt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BirgitBoss @zrgt