-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes #476
Merged
Merged
Minor changes #476
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cd48cfa
add issues link
BirgitBoss 87cf326
Formatting of "HasKind" inherited in Submodel
BirgitBoss b7438ab
add example for deprecated attribute in class in Annex UML
BirgitBoss 01ecccc
add xref to specifics
BirgitBoss feffda2
Remove comparison with semanticId to no have unnecessary dependencies
BirgitBoss 717646d
provide invalid und valid examples consistently throughout chapter
BirgitBoss aaa1e5f
AutomationML and OPC UA Mapping is not part of IDTA-01001 any longer:
BirgitBoss 98698c7
provide valid examples that is often considers to be a bug
BirgitBoss bc3999f
correct copy/paste error
BirgitBoss 4259f20
improvde descrition of Key/value:
BirgitBoss 76bd0d8
correct figure: Reference->Reference dependency is already part of re…
BirgitBoss 0c15380
add missing text and link to Annex explaining different of templates,…
BirgitBoss 42ec9cb
correct xref link
BirgitBoss f6273d5
remove "To date", only two types are supported
BirgitBoss 03911ce
do not use term "I4.0 Component", it is not in the glossary
BirgitBoss 1c42c67
Fix xrefs
zrgt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
documentation/IDTA-01001/modules/ROOT/partials/diagrams/uml-basics/deprecated-attribute.puml
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we also remove numeration from other uml-basics PUML-files? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, I was wrong, it is better without numbering |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
@startuml | ||
!theme idta from https://raw.githubusercontent.com/admin-shell-io/aas-specs-antora/main/plantuml/ | ||
|
||
|
||
class Class1 { | ||
+attr: Class2 <<Deprecated>> | ||
} | ||
|
||
@enduml |
2 changes: 1 addition & 1 deletion
2
...ms/uml-basics/86-deprecated-elements.puml → ...diagrams/uml-basics/deprecated-class.puml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
@startuml | ||
!theme idta from https://raw.githubusercontent.com/admin-shell-io/aas-specs-antora/main/plantuml/ | ||
|
||
|
||
class Class1 <<Deprecated>> | ||
|
||
@enduml |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other occurrences in the spec? I have found 21 occurences of "I4.0 Component" in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, really but hopefully only in the Annex
https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/annex/concepts-aas.html
https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/annex/requirements.html
https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/annex/usage-metamodel.html#_composite_i4_0_components
Here it is more historic and would be ok. Only for Composite i4.0 components we need to rethink...