Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Dont install GA JDK17 bootjdk on alpine aarch64 #3805

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Nov 7, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Installing GA JDK17 aarch64 alpine linux as a bootjdk (using the adoptopenjdk_install role) is causing an error since the GA doesnt exist. We install a nightly version in the common role.

Theres an issue here to discuss merging the bootjdk installs in the common role and the adoptopenjdk_install role, but until then this pr will stop errors such as https://ci.adoptium.net/job/centos7_docker_image_updater/574/execution/node/77/log/ in the build image updater job

 > [5/5] RUN set -eux;  cd /ansible;  ansible-playbook -i hosts ansible/playbooks/AdoptOpenJDK_Unix_Playbook/main.yml -e "git_sha=8803a16b196c127edb73c33b63ec9ace14008fd5" --skip-tags="debug,hosts_file,hostname,adoptopenjdk,jenkins,nagios,superuser,docker,swap_file,crontab,nvidia_cuda_toolkit";  rm -rf /ansible; apk del ansible:
671.6 
671.6 TASK [adoptopenjdk_install : Download latest release (Linux/Alpine-Linux)] *****
672.3 FAILED - RETRYING: Download latest release (Linux/Alpine-Linux) (3 retries left).
678.1 FAILED - RETRYING: Download latest release (Linux/Alpine-Linux) (2 retries left).
683.8 FAILED - RETRYING: Download latest release (Linux/Alpine-Linux) (1 retries left).
689.6 fatal: [localhost]: FAILED! => {"attempts": 3, "changed": false, "dest": "/tmp/jdk17.tar.gz", "elapsed": 0, "msg": "Request failed", "response": "HTTP Error 404: Not Found", "status_code": 404, "url": "https://api.adoptium.net/v3/binary/latest/17/ga/alpine-linux/aarch64/jdk/hotspot/normal/eclipse?project=jdk"}

@Haroon-Khel Haroon-Khel changed the title unixPB: Dont install alpine aarch64 JDK17 bootjdk unixPB: Dont install GA alpine aarch64 JDK17 bootjdk Nov 7, 2024
@Haroon-Khel Haroon-Khel changed the title unixPB: Dont install GA alpine aarch64 JDK17 bootjdk unixPB: Dont install GA JDK17 bootjdk on alpine aarch64 Nov 7, 2024
@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Nov 7, 2024

Now that hyphens are removed in the boot jdk symlinks, they should be removed from the symlinks created in the Common role too, which this pr now includes

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@sxa
Copy link
Member

sxa commented Nov 7, 2024

Will we still have a JDK17 (Temurin EA or from elsewhere) installed on the machine to bootstrap the 17EA builds?

@Haroon-Khel
Copy link
Contributor Author

Will we still have a JDK17 (Temurin EA or from elsewhere) installed on the machine to bootstrap the 17EA builds?

Yes, line 183 will still install a nightly boot JDK17 on aarch64 alpine linux

@Haroon-Khel Haroon-Khel merged commit c195e3c into adoptium:master Nov 8, 2024
11 of 12 checks passed
@sxa sxa added this to the 2024-11 (November) milestone Nov 29, 2024
mahdipub pushed a commit to mahdipub/infrastructure that referenced this pull request Dec 5, 2024
* unixPB: Dont install alpine aarch64 JDK17 bootjdk

* Remove hyphens from symlinks in bootjdks installed from Common role

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants