-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: Dont install GA JDK17 bootjdk on alpine aarch64 #3805
Conversation
Now that hyphens are removed in the boot jdk symlinks, they should be removed from the symlinks created in the Common role too, which this pr now includes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
Will we still have a JDK17 (Temurin EA or from elsewhere) installed on the machine to bootstrap the 17EA builds? |
Yes, line 183 will still install a nightly boot JDK17 on aarch64 alpine linux |
* unixPB: Dont install alpine aarch64 JDK17 bootjdk * Remove hyphens from symlinks in bootjdks installed from Common role * typo
Installing GA JDK17 aarch64 alpine linux as a bootjdk (using the adoptopenjdk_install role) is causing an error since the GA doesnt exist. We install a nightly version in the common role.
Theres an issue here to discuss merging the bootjdk installs in the common role and the adoptopenjdk_install role, but until then this pr will stop errors such as https://ci.adoptium.net/job/centos7_docker_image_updater/574/execution/node/77/log/ in the build image updater job