Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(methods): remove management plane, require strong consistency #222

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

toumorokoshi
Copy link
Member

The introduction of the concept of management plane and data plane and it's subjective definition in the AEPs was leading to ambiguous guidance. Removing the mention of those concepts until a clearer criteria can be established.

This change requires that a decision must be made for strong consistency. As operations that are not strongly consistent can result in manual per-resource patches for declarative clients, require strong consistency for all standard methods.

🍱 Types of changes

What types of changes does your code introduce to AEP? Put an x in the boxes
that apply

  • Enhancement
  • New proposal
  • Migrated from google.aip.dev
  • Chore / Quick Fix

📋 Your checklist for this pull request

Please review the AEP Style and Guidance for
contributing to this repository.

General

The introduction of the concept of management plane and data plane
and it's subjective definition in the AEPs was leading to ambiguous
guidance. Removing the mention of those concepts until a clearer
criteria can be established.

This change requires that a decision must be made for strong
consistency. As operations that are not strongly consistent
can result in manual per-resource patches for declarative clients,
require strong consistency for all standard methods.
@toumorokoshi toumorokoshi requested a review from a team as a code owner September 14, 2024 04:01
Copy link

@wora wora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we break down this PR so we can discuss one thing at a time?

aep/general/0121/aep.md.j2 Outdated Show resolved Hide resolved
aep/general/0121/aep.md.j2 Show resolved Hide resolved
Copy link
Collaborator

@rofrankel rofrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an organization doesn't have the right infra to provide strongly consistent CRUD methods, does that mean the organization can't be AEP-compliant?

@toumorokoshi
Copy link
Member Author

If an organization doesn't have the right infra to provide strongly consistent CRUD methods, does that mean the organization can't be AEP-compliant?

It certainly makes the declarative clients inconsistent, and in turn buggy and often require some client-side custom logic to work around it.

There is an argument that declarative clients aren't necessary for some use cases - but I feel this kind of case could be argued for multiple parts of the AEPs. Every must will result in omitting some set of the APIs out there.

@toumorokoshi toumorokoshi merged commit d5f3482 into aep-dev:main Nov 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants