Ignore NO_OFFSET condition while commiting #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While committing, we should ignore the NO_OFFSET error code.
There is a note in the comments in the rdkafka.h file as follows, which corroborates this change:
If no partitions had valid offsets to commit this callback will be called
with \p err == RD_KAFKA_RESP_ERR__NO_OFFSET which is not to be considered
an error.