Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore NO_OFFSET condition while commiting #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ignore NO_OFFSET condition while commiting #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06372da
Ignore NO_OFFSET condition while commiting
Jan 4, 2017
7a34c9e
Add a comment to mention that ErrorCode _NO_OFFSET should be ignored
Jan 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/RdKafka/Consumer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ public void Unassign()

/// <summary>
/// Commit offsets for the current assignment.
/// If no partitions had valid offsets to commit this will throw
/// RdKafkaException with ErrorCode _NO_OFFSET which is not to be considered an error
/// </summary>
public Task Commit()
{
Expand Down