-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move spin orbit to basic settings #984
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
==========================================
+ Coverage 68.26% 69.05% +0.78%
==========================================
Files 110 115 +5
Lines 6211 6388 +177
==========================================
+ Hits 4240 4411 +171
- Misses 1971 1977 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @edan-bainglass, thank you for the work, looks nice and indeed makes sense to have the SoC in the basics.
LGTM!
Based on #978
This PR moves the spin orbit control from advanced to basic settings. It also simplifies/uniforms the basic settings UI.
Handles #981