Merge main to java-spi #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add pendo back
* chore: removing 'it' profile ci, parent pom and moving samples 'it' to 'test' * renaming '*IntegrationTest' to * updating docs and updating class names (updating file names wan't enough) * adding missing failsafe plugin * Update akka-javasdk-maven/akka-javasdk-parent/pom.xml Co-authored-by: Renato Cavalcanti <[email protected]> * Update akka-javasdk-maven/akka-javasdk-parent/pom.xml Co-authored-by: Renato Cavalcanti <[email protected]> * Update docs/src/modules/java/pages/event-sourced-entities.adoc Co-authored-by: Renato Cavalcanti <[email protected]> * Update docs/src/modules/java/pages/key-value-entities.adoc Co-authored-by: Renato Cavalcanti <[email protected]> * Update .github/workflows/ci.yml Co-authored-by: Renato Cavalcanti <[email protected]> * docs: add local console to getting started guide (#58) * docs: review support pages (#64) * addressing comments .+ back to IntegrationTest suffix * Revert "docs: review support pages (#64)" This reverts commit 493648d. * Revert "docs: add local console to getting started guide (#58)" This reverts commit 29311bf. * fixing import * removing snapshot version used when testing * renaming class --------- Co-authored-by: Renato Cavalcanti <[email protected]> Co-authored-by: Brent Eritou <[email protected]> Co-authored-by: Enno Runne <[email protected]>
Remove Pendo reporting from docs
patriknw
commented
Dec 19, 2024
| @@ -167,7 +167,8 @@ class SdkRunner private (dependencyProvider: Option[DependencyProvider]) extends | |||
| startContext.remoteIdentification, | |||
| startContext.tracerFactory, | |||
| dependencyProvider, | |||
| startedPromise) | |||
| startedPromise, | |||
| getSettings.devMode.map(_.serviceName)) | |||
| @@ -617,7 +619,7 @@ private final class Sdk( | |||
|
|
|||
| override val serviceInfo: SpiServiceInfo = | |||
| new SpiServiceInfo( | |||
| serviceName = sdkSettings.devModeSettings.map(_.serviceName).getOrElse(""), | |||
| serviceName = serviceNameOverride.orElse(sdkSettings.devModeSettings.map(_.serviceName)).getOrElse(""), | |||
There was a problem hiding this comment.
... and this changed in 898ec6f#diff-26d7c802dc1ff7174ab9cbed72a852b5d31ce32af07c96b7686aa89a67fc328cR447
@efgpinto pls confirm that this is correct
There was a problem hiding this comment.
Yup, correct. looks good. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH