-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MI-85: Multi package managers & improvements #10
MI-85: Multi package managers & improvements #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but need to run this by a DevOps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments
@TheOrangePuff All issue has been addressed. I also update |
@TheOrangePuff Is there anything that block this PR to be merged? I understand that we do not have the final decision on which package manager we should use yet but this PR supports all 3 main one. Considering the following benefit, I think there is no harm of merging this even if we are going to stick with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is a bit big because I also fix a couple of issues while using this pipeline:
ts-node
instead of trans-pile to Javascript.ts-node
fromdependencies
.tsx
todevDependencies
for development.npm
package and run it directly from Bitbucket pipeline vianpx
.pipe.yml
. @tvhees I have no idea why this file exist in this repository. Do you recall why it's here & should it be removed or not?console.log()
& preserve colours from sub-commands. The result now look like so:@TheOrangePuff Will need your help on reviewing parts related to docker image building & workflow.