Merge pull request #329 from alphaville/feature/sphere.rs #331
Annotations
133 warnings
this expression creates a reference which is immediately dereferenced by the compiler:
src/constraints/sphere2.rs#L41
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/constraints/sphere2.rs:41:35
|
41 | x.copy_from_slice(¢er);
| ^^^^^^^ help: change this to: `center`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
binary comparison to literal `Option::None`:
src/constraints/rectangle.rs#L38
warning: binary comparison to literal `Option::None`
--> src/constraints/rectangle.rs:38:33
|
38 | assert!(xmin != None || xmax != None); // xmin or xmax must be Some
| ^^^^^^^^^^^^ help: use `Option::is_some()` instead: `xmax.is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
|
binary comparison to literal `Option::None`:
src/constraints/rectangle.rs#L38
warning: binary comparison to literal `Option::None`
--> src/constraints/rectangle.rs:38:17
|
38 | assert!(xmin != None || xmax != None); // xmin or xmax must be Some
| ^^^^^^^^^^^^ help: use `Option::is_some()` instead: `xmin.is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
= note: `#[warn(clippy::partialeq_to_none)]` on by default
|
this function has too many arguments (9/7):
src/alm/alm_problem.rs#L135
warning: this function has too many arguments (9/7)
--> src/alm/alm_problem.rs:135:5
|
135 | / pub fn new(
136 | | constraints: ConstraintsType,
137 | | alm_set_c: Option<AlmSetC>,
138 | | alm_set_y: Option<LagrangeSetY>,
... |
144 | | n2: usize,
145 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
|
this function has too many arguments (8/7):
src/alm/alm_factory.rs#L158
warning: this function has too many arguments (8/7)
--> src/alm/alm_factory.rs:158:5
|
158 | / pub fn new(
159 | | f: Cost,
160 | | df: CostGradient,
161 | | mapping_f1: Option<MappingF1>,
... |
166 | | n2: usize,
167 | | ) -> Self {
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
variable does not need to be mutable:
src/core/panoc/panoc_optimizer.rs#L65
warning: variable does not need to be mutable
--> src/core/panoc/panoc_optimizer.rs:65:27
|
65 | pub fn with_tolerance(mut self, tolerance: f64) -> Self {
| ----^^^^
| |
| help: remove this `mut`
|
variable does not need to be mutable:
src/core/fbs/fbs_optimizer.rs#L66
warning: variable does not need to be mutable
--> src/core/fbs/fbs_optimizer.rs:66:9
|
66 | mut self,
| ----^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
ci (ubuntu-20.04)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
ci (ubuntu-20.04)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci (ubuntu-20.04)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci (ubuntu-20.04)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci (ubuntu-20.04)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1418
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci (ubuntu-20.04)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1418
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci (ubuntu-20.04)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|
ci (ubuntu-20.04):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1418
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci (ubuntu-20.04):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci (ubuntu-20.04)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci (ubuntu-20.04)
`optimization_engine` (lib test) generated 6 warnings (1 duplicate) (run `cargo fix --lib -p optimization_engine --tests` to apply 5 suggestions)
|
ci (ubuntu-20.04)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|
ci (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1418
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci (ubuntu-latest)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1418
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci (ubuntu-latest)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|
ci (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci (ubuntu-latest)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci (ubuntu-latest):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci (ubuntu-latest):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci (ubuntu-latest)
`optimization_engine` (lib test) generated 6 warnings (1 duplicate) (run `cargo fix --lib -p optimization_engine --tests` to apply 5 suggestions)
|
ci (ubuntu-latest)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|
ci_macos (macos-11)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci_macos (macos-11)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11)
`optimization_engine` (lib test) generated 6 warnings (1 duplicate) (run `cargo fix --lib -p optimization_engine --tests` to apply 5 suggestions)
|
ci_macos (macos-11)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|
ci_macos (macos-11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci_macos (macos-11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci_macos (macos-11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci_macos (macos-11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci_macos (macos-11)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11)
`optimization_engine` (lib test) generated 6 warnings (1 duplicate) (run `cargo fix --lib -p optimization_engine --tests` to apply 5 suggestions)
|
ci_macos (macos-11)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/panoc/panoc_optimizer.rs#L65
variable does not need to be mutable
|
ci_macos (macos-11)
`optimization_engine` (lib) generated 2 warnings (run `cargo fix --lib -p optimization_engine` to apply 2 suggestions)
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1436
variable does not need to be mutable
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1461
variable does not need to be mutable
|
ci_macos (macos-11):
src/alm/alm_optimizer.rs#L1486
variable does not need to be mutable
|
ci_macos (macos-11):
src/core/fbs/fbs_optimizer.rs#L66
variable does not need to be mutable
|
ci_macos (macos-11)
`optimization_engine` (lib test) generated 6 warnings (1 duplicate) (run `cargo fix --lib -p optimization_engine --tests` to apply 5 suggestions)
|
ci_macos (macos-11)
the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, nom v4.2.3
|