o'clock fix #13
Merged
o'clock fix #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 40
💛 - Coveralls |
Open
alvinwan
reviewed
Feb 19, 2020
| @@ -37,6 +38,24 @@ def categorize(tokens, now): | |||
| return tokens | |||
|
|
|||
|
|
|||
| # TODO: add conversions for thirty, fourty-five | |||
There was a problem hiding this comment.
These conversions could actually be done by https://pypi.org/project/word2number/
Edit: adding word2number might be too much for a single PR. Just noting we don't have to build it ourselves
|
@alvinwan Thanks for all your help. Extra tests added, coverage increased. Hopefully, I'll get around to opening a few more PRs soon! |
|
@alvinwan Sorry about this, the build started failing as I think I forgot to test with pytest after my very last commit. I can open another PR but it won't be able to be automatically merged, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12
Fix parsing of "5 o'clock pm", "five o'clock pm" and "five o'clock".
Create a separate function to convert all word numbers to digit numbers.
Add 2 tests for new function and 2 extra tests to
maybe_substitute_hour_minutefunction.All tests on pytest passing.