deprecation: Remove OQC #1014
Merged
deprecation: Remove OQC #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,7 @@ class _Xanadu(str, Enum): | |||
| # DWave = _DWave | |||
| IonQ = _IonQ | |||
| IQM = _IQM | |||
| OQC = _OQC | |||
| # OQC = _OQC | |||
There was a problem hiding this comment.
Intentionally commenting this instead of removing this from the Enums?
There was a problem hiding this comment.
Just doing the same thing we've done with D-Wave and Xanadu
virajvchaudhari
previously approved these changes
Jun 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 135 135
Lines 8951 8950 -1
Branches 2014 2014
=========================================
- Hits 8951 8950 -1 ☔ View full report in Codecov by Sentry. |
virajvchaudhari
previously approved these changes
Jun 28, 2024
|
There are few more places to remove? |
| @@ -77,7 +73,7 @@ def test_get_devices_others(): | |||
|
|
|||
| def test_get_devices_all(braket_devices): | |||
| result_arns = [result.arn for result in braket_devices] | |||
| for arn in [RIGETTI_ARN, IONQ_ARN, SIMULATOR_ARN, OQC_ARN]: | |||
| for arn in [RIGETTI_ARN, IONQ_ARN, SIMULATOR_ARN]: | |||
There was a problem hiding this comment.
Why haven't we added IQM_ARN here as well?
There was a problem hiding this comment.
Sure, I'm fine with that
virajvchaudhari
approved these changes
Jun 28, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.