Skip to content

Commit

Permalink
after open hook fix
Browse files Browse the repository at this point in the history
  • Loading branch information
angrykoala committed Oct 13, 2018
1 parent 384e773 commit 916c751
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 5 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
1.5.0 / ####-##-##
1.4.2 / ####-##-##
==================

* AddScript method
* After Open hook fix
* Minor improvements to some error messages

1.4.1 / 2018-10-13
==================
Expand Down
2 changes: 1 addition & 1 deletion lib/browser_core.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports = class BrowserCore {
return this._afterPageLoad();
});
}).catch((err) => {
return Promise.reject(new FatalError(`Failed to open ${url}. ${err.message}`));
return Promise.reject(new FatalError(`Failed to open "${url}". ${err.message}`));
});
}

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "wendigo",
"version": "1.4.1",
"version": "1.4.2",
"description": "A proper monster for front-end automated testing",
"engines": {
"node": ">=8.0.0"
Expand Down
2 changes: 1 addition & 1 deletion tests/browser/open.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe("Open", function() {
it("Open Fails", async() => {
await utils.assertThrowsAsync(async() => {
await browser.open("not-a-page");
}, `FatalError: Failed to open not-a-page. Protocol error (Page.navigate): Cannot navigate to invalid URL`);
}, `FatalError: Failed to open "not-a-page". Protocol error (Page.navigate): Cannot navigate to invalid URL`);
});

it("Before Open Fails", async() => {
Expand Down

0 comments on commit 916c751

Please sign in to comment.