Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #582

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Fix CI #582

merged 3 commits into from
Feb 17, 2024

Conversation

nre-ableton
Copy link
Contributor

@nre-ableton nre-ableton commented Jan 16, 2024 •
edited
Loading

Attempting to install netaddr in tasks/main.yml resulted in an error:

ERROR: Can not perform a '--user' install. User site-packages are not visible in this virtualenv.

Fortunately, we already install netaddr in prepare.yml and can define consul_install_dependencies: false, since we don't require any other dependencies.

This PR also updates the checkout and molecule GitHub actions to their latest versions.

@nre-ableton nre-ableton force-pushed the nre/master/fix-ci branch 2 times, most recently from 825f339 to f4190d5 Compare January 17, 2024 10:47
@bbaassssiiee bbaassssiiee mentioned this pull request Jan 17, 2024
Merged
@bbaassssiiee bbaassssiiee mentioned this pull request Feb 15, 2024
Closed
@nre-ableton nre-ableton force-pushed the nre/master/fix-ci branch 3 times, most recently from d826731 to 20ede52 Compare February 15, 2024 10:47
@nre-ableton
Don't install netaddr in molecule tests
1f61f12 
We already install it in the prepare.yml playbook. Installing it via pip
with `--user` fails when run in the Docker Container used by the GitHub
Action CI check.
@nre-ableton nre-ableton changed the title WIP: Fix CI Fix CI Feb 15, 2024
@nre-ableton nre-ableton marked this pull request as ready for review February 15, 2024 11:04
bbaassssiiee
bbaassssiiee approved these changes Feb 17, 2024
View reviewed changes
Copy link
Member

@bbaassssiiee bbaassssiiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray! CI fixed!

@bbaassssiiee bbaassssiiee merged commit 532a9be into ansible-collections:master Feb 17, 2024
16 checks passed
@nre-ableton
Copy link
Contributor Author

@bbaassssiiee thanks for merging!

@nre-ableton nre-ableton deleted the nre/master/fix-ci branch February 19, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbaassssiiee bbaassssiiee bbaassssiiee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nre-ableton @bbaassssiiee