Feature filter keep_keys #8456
Merged
Feature filter keep_keys #8456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vbotka this PR contains the following merge commits: Please rebase your branch to remove these commits. |
ansibullbot
added
merge_commit
vbotka
force-pushed
the
feature-filter-keep_key-v2
branch
from
6714409 to
c97fc2d
Compare
ansibullbot
added
integration
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
felixfontein
added
check-before-release
felixfontein
reviewed
Jun 2, 2024
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
ansibullbot
added
needs_ci
Co-authored-by: Felix Fontein <[email protected]>
Closed
1 task
felixfontein
reviewed
Jun 3, 2024
target is list. Update documentation, function comments, and error messages.
Co-authored-by: Felix Fontein <[email protected]>
vbotka
added a commit
to vbotka/community.general
that referenced
this pull request
Jun 3, 2024
This was referenced Jun 3, 2024
felixfontein
approved these changes
Jun 3, 2024
felixfontein
removed
the
check-before-release
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #8462 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Add filter keep_keys. Implement feature request #8438 * Fix comment indentation. * Fix regex reference. * Fix indentation. * Fix isinstance list. * Update plugins/plugin_utils/keys_filter.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/plugin_utils/keys_filter.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/plugin_utils/keys_filter.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/plugin_utils/keys_filter.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/keep_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update documentation, examples, and integration tests. * _keys_filter_target_str returns tuple of unique target strings if target is list. Update documentation, function comments, and error messages. * Sort maintainers. * Update plugins/filter/keep_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update examples with explicit collection. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 6f8f12f)
|
Thanks for contributing this @vbotka! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 4, 2024
Feature filter keep_keys (#8456) * Add filter keep_keys. Implement feature request #8438 * Fix comment indentation. * Fix regex reference. * Fix indentation. * Fix isinstance list. * Update plugins/plugin_utils/keys_filter.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/plugin_utils/keys_filter.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/plugin_utils/keys_filter.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/plugin_utils/keys_filter.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/keep_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update documentation, examples, and integration tests. * _keys_filter_target_str returns tuple of unique target strings if target is list. Update documentation, function comments, and error messages. * Sort maintainers. * Update plugins/filter/keep_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update examples with explicit collection. --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 6f8f12f) Co-authored-by: Vladimir Botka <[email protected]>
|
Thank you @felixfontein! |
vbotka
added a commit
to vbotka/community.general
that referenced
this pull request
Jun 4, 2024
felixfontein
added a commit
that referenced
this pull request
Jun 6, 2024
* Add filter remove_keys. * Add filter remove_keys integration test, fragment, and maintainer. * Update with plugins/plugin_utils/keys_filter.py * Update according PR #8456 * Update maintainers. * Fix typo in return doc. * Remove local keys_filter.py. Then rebase. * Add local keys_filter.py * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]>
patchback bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Add filter remove_keys. * Add filter remove_keys integration test, fragment, and maintainer. * Update with plugins/plugin_utils/keys_filter.py * Update according PR #8456 * Update maintainers. * Fix typo in return doc. * Remove local keys_filter.py. Then rebase. * Add local keys_filter.py * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 06f13e7)
felixfontein
pushed a commit
that referenced
this pull request
Jun 7, 2024
) Feature filter remove_keys (#8443) * Add filter remove_keys. * Add filter remove_keys integration test, fragment, and maintainer. * Update with plugins/plugin_utils/keys_filter.py * Update according PR #8456 * Update maintainers. * Fix typo in return doc. * Remove local keys_filter.py. Then rebase. * Add local keys_filter.py * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> * Update plugins/filter/remove_keys.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 06f13e7) Co-authored-by: Vladimir Botka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ansible.utils.keep_keys does not work properly. Fixing is not efficient.
ISSUE TYPE
New Module/Plugin Pull Request
COMPONENT NAME
community.general.keep_keys
ADDITIONAL INFORMATION
This PR implements #8438