Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8456/6f8f12f7 backport][stable-9] Feature filter keep_keys #8462

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 4, 2024

This is a backport of PR #8456 as merged into main (6f8f12f).

SUMMARY
ansible.utils.keep_keys does not work properly. Fixing is not efficient.

ISSUE TYPE
New Module/Plugin Pull Request

COMPONENT NAME
community.general.keep_keys

ADDITIONAL INFORMATION
This PR implements #8438

* Add filter keep_keys. Implement feature request #8438

* Fix comment indentation.

* Fix regex reference.

* Fix indentation.

* Fix isinstance list.

* Update plugins/plugin_utils/keys_filter.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/plugin_utils/keys_filter.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/plugin_utils/keys_filter.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/plugin_utils/keys_filter.py

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/filter/keep_keys.py

Co-authored-by: Felix Fontein <[email protected]>

* Update documentation, examples, and integration tests.

* _keys_filter_target_str returns tuple of unique target strings if
target is list. Update documentation, function comments, and error
messages.

* Sort maintainers.

* Update plugins/filter/keep_keys.py

Co-authored-by: Felix Fontein <[email protected]>

* Update examples with explicit collection.

---------

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 6f8f12f)
@patchback patchback bot mentioned this pull request Jun 4, 2024
@ansibullbot
Copy link
Collaborator

cc @vbotka
click here for bot help

@ansibullbot ansibullbot added backport filter filter plugin integration tests/integration new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Jun 4, 2024
@felixfontein felixfontein merged commit 3bca21a into stable-9 Jun 4, 2024
131 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-9/6f8f12f762365686e18ce4a2bb0847b1c8b79cc7/pr-8456 branch June 4, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport filter filter plugin integration tests/integration new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants