[ISSUE #4658] Add documentation for dingtalk sink connector. #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
approved these changes
Dec 16, 2023
Pil0tXia
reviewed
Dec 16, 2023
Comment on lines
+2
to
+4
|
|
||
| ## DingtalkSinkConnector：from eventmesh to dingtalk。 | ||
|
|
There was a problem hiding this comment.
It will be better to remove this CN period and use EventMesh and DingTalk instead. Or I will do it later.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4660 +/- ##
=========================================
Coverage 17.39% 17.39%
- Complexity 1758 1759 +1
=========================================
Files 797 797
Lines 29787 29787
Branches 2575 2575
=========================================
+ Hits 5180 5182 +2
+ Misses 24129 24128 -1
+ Partials 478 477 -1 ☔ View full report in Codecov by Sentry. |
pandaapo
reviewed
Dec 16, 2023
| ```yaml | ||
| pubSubConfig: | ||
| # default port is 10000 | ||
| meshAddress: 127.0.0.1:10000 |
There was a problem hiding this comment.
Could you change it to your.eventmesh.server:10000 like this document? This may be clearer.
能否像该文档一样改成这样your.eventmesh.server:10000 ？这样也许更明确。
pandaapo
reviewed
Dec 16, 2023
| @@ -0,0 +1,26 @@ | |||
| # eventmesh-connector-dingtalk | |||
There was a problem hiding this comment.
This connector has requirements for data properties, but it seems that your document does not specify them. #4591 (comment)
该Connector对数据的属性是有要求的，您的文档好像没有说明。#4591 (comment)
xwm1992
approved these changes
Dec 16, 2023
mxsm
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4658
Modifications
Add documentation for dingtalk sink connector.