[ISSUE #4665] Optimize and sync recent new connectors' docs #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2023
Pil0tXia
force-pushed
the
pil0txia_enhance_4665
branch
from
18d5c63 to
cafa7e3
Compare
Pil0tXia
force-pushed
the
pil0txia_enhance_4665
branch
from
cbc2727 to
3b1f204
Compare
pandaapo
reviewed
Dec 16, 2023
| ```yaml | ||
| pubSubConfig: | ||
| # default port is 10000 | ||
| # default port 10000 | ||
| meshAddress: 127.0.0.1:10000 |
There was a problem hiding this comment.
127.0.0.1:10000 may be optimized to your.eventmesh.server:10000 like this document. The same applies to several other documents.
There was a problem hiding this comment.
Updated dingtalk, wocom, slack in ae41084 ~
| When using the eventmesh-connector-wecom sinking event, you need to add the corresponding extension filed in CloudEvent: | ||
|
|
||
| - When key=`wecomTemplateType`, value=`text`/`markdown`, indicating the text type of the event. |
There was a problem hiding this comment.
It should be wecomtemplatetype.
pandaapo
reviewed
Dec 16, 2023
| When using the eventmesh-connector-dingtalk sinking event, you need to add the corresponding extension filed in CloudEvent: | ||
|
|
||
| - When key=`dingtalkTemplateType`, value=`text`/`markdown`, indicating the text type of the event. |
There was a problem hiding this comment.
It should be dingtalktemplatetype. Additionally, please help add that when dingtalktemplatetype‘s value is markdown, you can set a title for the markdown text: key=dingtalkmarkdownmessagetitle, value=your title.
应该是dingtalktemplatetype。另外，还请帮忙加上，当dingtalktemplatetype的value是markdown时，可以为markdown文本设置标题：key=dingtalkmarkdownmessagetitle，value=您的标题。
xwm1992
approved these changes
Dec 17, 2023
|
@mxsm PTAL~ |
pandaapo
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4665.
Motivation
#4665
Modifications
Documentation