FINERACT-1981: When paying down payment, that should not be reflected on the InterestModel #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Oct 31, 2024
| @@ -1560,6 +1560,12 @@ private Money handlingPaymentAllocationForInterestBearingProgressiveLoan(LoanTra | |||
| paidPortion = processPaymentAllocation(paymentAllocationType, installment, loanTransaction, transactionAmountUnprocessed, | |||
| loanTransactionToRepaymentScheduleMapping, charges, balances, LoanRepaymentScheduleInstallment.PaymentAction.PAY); | |||
|
|
|||
| if (installment.isDownPayment() || installment.getDueDate().isAfter(ctx.getModel().getMaturityDate())) { | |||
There was a problem hiding this comment.
You can check whether it is down payment or additional and also we should not do the updateRepaymentPeriodBalances either in line 1557
There was a problem hiding this comment.
Also, please add some testing as well:
- Downpayment is configured on the loan
- We can pay the down payment and the regular installments
- Calculated balances are correct
kulminsky
force-pushed
the
FINERACT-1981/When-paying-down-payment-that-should-not-be-reflected-on-the-InterestModel
branch
from
3ccba53 to
2332200
Compare
… on the InterestModel
kulminsky
force-pushed
the
FINERACT-1981/When-paying-down-payment-that-should-not-be-reflected-on-the-InterestModel
branch
from
2332200 to
4e391fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When paying down payment, that should not be reflected on the InterestModel
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.