Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from NUnit 2.6.3 to NUnit 3.5.0 #194

Merged
merged 5 commits into from
Dec 16, 2016
Merged

Updating from NUnit 2.6.3 to NUnit 3.5.0 #194

merged 5 commits into from
Dec 16, 2016

Conversation

conniey
Copy link
Contributor

@conniey conniey commented Nov 12, 2016

Updates the current test projects to NUnit 3.5.0.

  • Replaces obsolete TestFixtureSetUp and TestFixtureTearDown with OneTimeSetUp and OneTimeTearDown
  • Replaces [ExpectedException] with Assert.Throws<T>
  • Adds a reason for [Ignore] tests because it is required now

Is there anything I need to edit in make it work in TeamCity?

PR #191 depends on this because dotnet-test-nunit uses NUnit 3.5.0

@conniey
Copy link
Contributor Author

conniey commented Nov 22, 2016

@synhershko @NightOwl888 Is there anything I need to do to get this merged in?

@synhershko
Copy link
Contributor

Looks good to me, but seems like it's blocked by #191?

@conniey
Copy link
Contributor Author

conniey commented Dec 16, 2016

@synhershko This doesn't depend on #191. I created this PR off of master.

@synhershko
Copy link
Contributor

Ok, cool, merging now

@NightOwl888
Copy link
Contributor

@synhershko

I reverted these commits because we already have this change in #191 and it causes a conflict, not to mention it breaks the build (see #200).

@synhershko
Copy link
Contributor

Cool thanks - that's why I asked before merging...

@conniey
Copy link
Contributor Author

conniey commented Dec 22, 2016

@synhershko @NightOwl888 When I had opened this PR, no one was working on my branch, so I was going to rebase my commits on top of this so there would be less changes to look at in #191. :) But since there is active development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants