Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nunit 3 console package to enable TeamCity to run the tests. #200

Closed
wants to merge 1 commit into from

Conversation

wwb
Copy link
Contributor

@wwb wwb commented Dec 19, 2016

Adding Nunit 3 console package to enable TeamCity to run the nunit 3.5 tests.

@NightOwl888
Copy link
Contributor

Hi, does this have anything to do with #194? We should probably revert that change, since it causes a conflict with #191 (which we are actively working on).

We really should be working off of #191 only at this point.

@wwb
Copy link
Contributor Author

wwb commented Dec 19, 2016

Yes -- this is to keep TeamCity running with that in play. You can reject this one and revert that.

It would be cool to get #191 merged so we can get TeamCity working with the new layout, not sure what is between us and that though.

@wwb wwb closed this Dec 19, 2016
@NightOwl888
Copy link
Contributor

NightOwl888 commented Dec 19, 2016

It would be cool to get #191 merged so we can get TeamCity working with the new layout, not sure what is between us and that though.

I know there is at least:

  • Tests that are failing/running infinitely over there that are not on master
  • Working out what to do about the build/TeamCity. The build script is setup to run the build for the entire solution at once. But you seem to be running one project at a time (at least for testing). Is there any reason we can't just hook into a single build script that does the build? Or should we aim to make the build script work at the project level?

It looks like @conniey already setup a TeamCity task to run the build once we get over there, but I am still unsure it can accept our current versioning scheme (which I have confirmed will do the trick and I think we should keep).

@wwb
Copy link
Contributor Author

wwb commented Dec 19, 2016

If you are talking about this one -- I set that one up to wrap my head around what needed to change to run the new version of the project. It still isn't quite perfect but it is getting there. Currently I am using build.ps1 to build things. I am still working on getting the tests to run successfully. It can easily be made to accept the current versioning once we unify the codebase.

The individual project builds and tests are at @synhershko 's request. Mechanically, the Lucene.net.core build is the real build and test with the nightly generating the myget packages. At the end of the day the build system has to take into account that we want individual packages for the sub-projects.

In terms of a path forward I suggest that we just get a clean build up with the core things in place and then fix the tests -- as well as build out nuget packaging. How we want to build it changes based on the new structure so we might as well get that in place and build on top of it.

@wwb wwb deleted the nunit-console branch December 19, 2016 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants