Fixes several slow tests (#295) #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll. Improvement of 15%
…nit seems to not treat these as numerics or at least elongates test times. Did the same for byte comparisons.
…numerable to IList to take advantage of indexing
…() and Count() LINQ methods, fixed boxing issue with the Assert.AreEquals call when comparing files (addresses apache#295).
…alls to ElementAt() and Count() LINQ (Addresses apache#261)
…dated assertEquals overloads to support additional collection types
…rongly-typed overloads are being called to reduce boxing. (addresses apache#295, apache#261)
…ged test to utilize the J2N's ArrayEqualityComparer to optimize the speed of the test (apache#295, apache#261)
…th Assert.AreEqual
…ith J2N.Collections.ArrayEqualityComparer<T> before cascading only the failing calls to NUnit.CollectionAssert.AreEqual to generate the error message (apache#295, apache#261)
… the Assert class in the test framework instead of NUnit (apache#295, apache#261)
…t framework instead of NUnit (apache#295, apache#261)
…s.Document: Switched to using the Assert class from the test framework instead of NUnit (apache#295, apache#261)
…t framework instead of NUnit (apache#295, apache#261).
…s from the test framework instead of NUnit (apache#295, apache#261)
…est framework instead of NUnit (apache#295, apache#261)
…rray(): Optimized by comparing against string, since indexing into a StringBuilder is painfully slow in .NET
This was
linked to
issues
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes performance of several tests by eliminating boxing/unboxing when passing arguments to test asserts. We already had our own facade
Assertclass, but needed to extend it with overloads for primitive types.In addition, one of the contributors of the slowness of
OfflineSorterhas been addressed, as well as the primary contributor to the slowness of theLucene.Net.Facet.Taxonomy.WriterCache.TestCharBlockArray.TestArraytest.Based on several runs on Azure DevOps, this reduces the average testing time by approximately 10 minutes (45min average instead of 55min). Running the tests sequentially in Visual Studio locally now takes ~35min (before it was around 1 hour).