Code

Fixes several slow tests (#295)#298

Code

Merged

NightOwl888 merged 26 commits intoapache:masterapache/lucenenet:masterfrom NightOwl888:fix/slow-util-tests-1NightOwl888/lucenenet:fix/slow-util-tests-1Copy head branch name to clipboardJun 24, 2020

+1,051-604

Commits

Commits on Jun 20, 2020

• Reformated Debug assert call with String.Format with interpolation call. Improvement of 15%

  

  Michael

  committed
  c3c90c8

Commits on Jun 23, 2020

• addresses apache#295 optimised some Assert calls using long, long. NUnit seems to not treat these as numerics or at least elongates test times.

  Show description for aa22fe3
  

  Michael

  committed
  aa22fe3

• addresses apache#295 updated lucene test case asserts and modified IEnumerable to IList to take advantage of indexing

  

  Michael

  committed
  baea0a4

• Updated to passive from aggressive

  

  Michael

  committed
  a64198f

• commented unused code throwing an expection and slowing test

  

  Michael

  committed
  0f524e8

• added

  Show description for e0b59b0
  

  Michael

  committed
  e0b59b0

• Lucene.Net.Util.OfflineSorter: Removed unnecessary calls to ElementAt() and Count() LINQ methods, fixed boxing issue with the Assert.AreEquals call when comparing files (addresses apache#295).

  NightOwl888

  committed
  9362a4e

• Lucene.Net.Tests.Suggest.Fst.FSTCompletionTest: Removed unnecessary calls to ElementAt() and Count() LINQ (Addresses apache#261)

  NightOwl888

  committed
  a17936a

• Lucene.Net.TestFramework: Added overloads for int to Assert.AreEqual (addresses apache#295, apache#261)

  NightOwl888

  committed
  4af199b

• Lucene.Net.TestFramework.Support.JavaCompatibility.LuceneTestCase: Updated assertEquals overloads to support additional collection types

  NightOwl888

  committed
  4aac3cb

• SWEEP: Lucene.Net.Util: Added using for Assert class to ensure our strongly-typed overloads are being called to reduce boxing. (addresses apache#295, apache#261)

  NightOwl888

  committed
  acd6722

• Lucene.Net.Tests.Util.TestOfflineSorter::AssertFilesIdentical(): Changed test to utilize the J2N's ArrayEqualityComparer to optimize the speed of the test (apache#295, apache#261)

  NightOwl888

  committed
  6eeece6

• Lucene.Net.Tests.Index.TestIndexWriter: Fixed ambiguous call issue with Assert.AreEqual

  NightOwl888

  committed
  61f7fd7

• Lucene.Net.TestFramework: Optimized array asserts by first checking with J2N.Collections.ArrayEqualityComparer<T> before cascading only the failing calls to NUnit.CollectionAssert.AreEqual to gener…

  Show description for 2563735
  NightOwl888

  committed
  2563735

Commits on Jun 24, 2020

• Lucene.Net.Tests.Search + Lucene.Net.Tests.Support: Switched to using the Assert class in the test framework instead of NUnit (apache#295, apache#261)

  NightOwl888

  committed
  a5e37b9

• Lucene.Net.Tests.Index: Switched to using the Assert class in the test framework instead of NUnit (apache#295, apache#261)

  NightOwl888

  committed
  218b4e2

• Lucene.Net.Tests.Analysis + Lucene.Net.Tests.Codecs + Lucene.Net.Tests.Document: Switched to using the Assert class from the test framework instead of NUnit (apache#295, apache#261)

  NightOwl888

  committed
  b62684c

• Lucene.Net.Tests.ICU: Switched to using the Assert class from the test framework instead of NUnit (apache#295, apache#261).

  NightOwl888

  committed
  c5d6e92

• Lucene.Net.Tests.Analysis.Phonetic: Switched to using the Assert class from the test framework instead of NUnit (apache#295, apache#261)

  NightOwl888

  committed
  f6404d3

• Lucene.Net.Tests.Facet: Switched to using the Assert class from the test framework instead of NUnit (apache#295, apache#261)

  NightOwl888

  committed
  50017c4

• Lucene.Net.TestFramework: Added assert overloads for float (apache#295, apache#261)

  NightOwl888

  committed
  353e423

• Lucene.Net.Tests.Facet.Taxonomy.WriterCache.TestCharBlockArray::TestArray(): Optimized by comparing against string, since indexing into a StringBuilder is painfully slow in .NET

  NightOwl888

  committed
  7de8168

• Lucene.Net.TestFramework: Removed SeedAttribute

  NightOwl888

  committed
  ec82f82

• run-tests-on-os.yml: Upgraded to .NET Core SDK 3.1.301

  NightOwl888

  committed
  ffe30d3

• Downgraded tests from netcoreapp2.2 to netcoreapp2.1 because 2.2 is no longer supported and 2.1 is: https://devblogs.microsoft.com/dotnet/net-core-2-2-will-reach-end-of-life-on-december-23-2019/

  NightOwl888

  committed
  500a055

• run-tests-on-os.yml: Added task to install .NET Core SDK 2.1

  NightOwl888

  committed
  ff4937f