Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create benchmark #14916

Draft
wants to merge 2 commits into
base: 09-11-permission_for_framework
Choose a base branch
from
Draft

Create benchmark #14916

wants to merge 2 commits into from
+111 −19

Conversation

runtian-zhou
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Oct 9, 2024 •
edited
Loading

⏱️ 1h 51m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-targeted-unit-tests 24m 🟥 
rust-move-tests 11m 🟩 
rust-cargo-deny 10m 🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-move-tests 10m 🟥 
rust-move-tests 10m 🟩 
rust-move-tests 10m 🟩 
rust-move-tests 10m 🟥 
rust-move-tests 10m 🟩 
check-dynamic-deps 6m 🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-lints 4m 🟥 
general-lints 3m 🟩 🟩 🟩 🟩 🟩 (+1 more)
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 (+1 more)
rust-check-merge-base 1m 🟩 
file_change_determinator 58s 🟩 🟩 🟩 🟩 🟩 
permission-check 21s 🟩 🟩 🟩 🟩 🟩 (+1 more)

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

This was referenced Oct 9, 2024
Draft
Draft
Draft
Draft
Draft
@runtian-zhou Graphite App
Copy link
Contributor Author

runtian-zhou commented Oct 9, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@runtian-zhou runtian-zhou mentioned this pull request Oct 9, 2024
Open
21 tasks
@rahxephon89 rahxephon89 force-pushed the 09-11-permission_for_framework branch from 43f2715 to d468098 Compare October 9, 2024 21:45
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch 3 times, most recently from 6c002e4 to 44e71be Compare October 9, 2024 23:23
@runtian-zhou runtian-zhou force-pushed the 10-09-create_benchmark branch 2 times, most recently from ef3c832 to e2fcd91 Compare November 18, 2024 21:33
graphite-app[bot]
graphite-app bot reviewed Nov 21, 2024
View reviewed changes
testsuite/module-publish/src/packages/framework_usecases/sources/permissioned_transfer.move
Comment on lines +1 to +17

module 0xABCD::permissioned_transfer {
use aptos_framework::aptos_account;
use aptos_framework::fungible_asset;
use aptos_framework::permissioned_signer;

public entry fun transfer_permissioned(
source: &signer, to: address, amount: u64
) {
let handle = permissioned_signer::create_permissioned_handle(source);
let permissioned_signer = permissioned_signer::signer_from_permissioned(&handle);

fungible_asset::grant_apt_permission(source, &permissioned_signer, amount);
aptos_account::transfer(&permissioned_signer, to, amount);

permissioned_signer::destroy_permissioned_handle(handle);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the permissioned_transfer function and its dependencies since it relies on Move 2.0 enum types through the permissioned_signer module. Keep only the basic transfer function until Move 2.0 features are enabled in the testing environment.

Spotted by Graphite Reviewer (based on CI logs)

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@runtian-zhou