Move collection addr and fa addr to env #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
0xmaayan
reviewed
Sep 4, 2024
| @@ -5,6 +5,9 @@ All notable changes to the create-aptos-dapp tool will be captured in this file. | |||
| # Unreleased | |||
|
|
|||
| - Code cleanup, always use env var from constants | |||
| - Rename `collection_id` to `collection_address` in the NFT minting template | |||
| - Move `collection_address` and `fa_address` from `config.ts` to the `.env` file in the minting templates | |||
| - Support devnet for token minting template, nft minting is not supported on devnet because it depends on token-minter contract which is not deployed on devnet | |||
There was a problem hiding this comment.
we can't support token minting dapp on devnet because it depends on Irys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested both template by running them locally
Doc PR aptos-labs/developer-docs#578