CI: add JDK 21 (LTS) to testing matrix. #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starksm64
approved these changes
Jul 13, 2024
jamezp
reviewed
Jul 15, 2024
| distribution: temurin | ||
| cache: maven | ||
| - name: Build with Maven | ||
| run: mvn --batch-mode --no-transfer-progress clean verify |
There was a problem hiding this comment.
Late reply, but if we want to run integration tests here we need something like -Pintegration-tests -Pwildfly as well.
There was a problem hiding this comment.
Do we? I was thinking that this will suffice (for now).
There was a problem hiding this comment.
Yes. The integration tests are not enabled by default. There might be a better way to do it with a single profile, but this is what was currently done. You can run with -Pintegration-tests -Pwildfly or -Pintegration-tests -Ppayara.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the call.