Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add JDK 21 (LTS) to testing matrix. #599

Merged
merged 1 commit into from
Jul 13, 2024
Merged

CI: add JDK 21 (LTS) to testing matrix. #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,19 @@ jobs:
cache: maven
- name: Build with Maven
run: mvn --batch-mode --no-transfer-progress clean verify

arquillian-build-jdk21:
name: Integration - JDK 21
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- name: Build with Maven
uses: actions/checkout@v4
- name: Setup JDK 21
uses: actions/setup-java@v4
with:
java-version: 21
distribution: temurin
cache: maven
- name: Build with Maven
run: mvn --batch-mode --no-transfer-progress clean verify
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late reply, but if we want to run integration tests here we need something like -Pintegration-tests -Pwildfly as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we? I was thinking that this will suffice (for now).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The integration tests are not enabled by default. There might be a better way to do it with a single profile, but this is what was currently done. You can run with -Pintegration-tests -Pwildfly or -Pintegration-tests -Ppayara.