Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi stage build for demo_pipeline #84

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

romanodanilo
Copy link
Contributor

Description

Refactor docker file:

  • framework_builder is responsibile for building the framework and also cloning the repositories needed for demo pipeline. It also creates 4 python virtual environments to enhance isolation: openscenario-venv, opendrive-venv, runtime-venv and demo-pipeline-venv
  • Runtime now based on ubuntu image and using python runtime-venv
  • Demo pipeline copying all necessary files from framework-builder and activating the corresponding venvs

How was the PR tested?

  1. Unit-test with sample data. All unit tests passed.

Notes

@romanodanilo romanodanilo marked this pull request as ready for review June 18, 2024 09:57
Copy link
Collaborator

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanodanilo

@hoangtungdinh hoangtungdinh merged commit 0912678 into develop Jun 18, 2024
4 checks passed
@hoangtungdinh hoangtungdinh deleted the danilo/add_multi_stage_demo_pipeline branch June 18, 2024 10:43
hoangtungdinh pushed a commit that referenced this pull request Jun 18, 2024
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants