Implementation for SWS scale #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 760fb8c.
|
Let me know when your draft is done so that I know when to start reviewing it 👍 |
Cacsjep
changed the title
|
done it works for my application gg, hope its fit to your needs =) |
Change scaling example to an similar libav example Update readme Add func to UpdateScalingParameters Rename AllocSwsContext to SwsGetContext Using a type for scaling algos/flags
|
I did some improvments based on your feedback on my hw_context pr :) Br |
asticode
requested changes
Jan 24, 2024
Now using sws context flags Restructer sws context and adding ned simpler methods to update the ctx Update the example Update the test
|
ok this was a lot, hope i dont miss anything |
Get/Set source w,h,pixfmt Get/Set dst w,h,pixfmt Get/Set sws flags
|
I think it would also be cool to have one setter for width and height, because most of time user would be change both, currently we would call updateContext twice. func (ssc *SoftwareScaleContext) SetSourceResolution(w int, h int) error {
ssc.srcW = C.int(w)
ssc.srcH = C.int(h)
return ssc.updateContext()
}
func (ssc *SoftwareScaleContext) SetDestinationResolution(w int, h int) error {
ssc.dstW = C.int(w)
ssc.dstH = C.int(h)
return ssc.updateContext()
}I think its better to have this and not calling it twice so i add it and let me know if this ok for you =) |
asticode
requested changes
Jan 26, 2024
Reorder flags, and update them # Update Example Use renaming function to create sws context Clean up Use new framdata image funcs # Sws scale context New way to update the context Use sws_scale_frame instead of sws_scale Reordering funcs for get and set # Sws sclate context flag Add "Flag" for algo name # Update sws test
|
ok done lets go to next round ;) |
Simpfy sws update Use c.int for sws flags update test
|
Great, I'll merge the PR and make minor adjustments 👍 |
|
Perfect, thank you for letting me contribute =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I am starting with implementation sws scale, hope we can start here as a draft so that we add this to go-astiv =)
br